Refactor tests to use parameterized tests 676#14138
Merged
Merged
Conversation
koppor
requested changes
Oct 22, 2025
Member
There was a problem hiding this comment.
Good first step, but we really should increase readability.
Please learn at https://mikemybytes.com/2021/10/19/parameterize-like-a-pro-with-junit-5-csvsource/ how to write nicely formatted JUnit CsvSource.
- Using
->as delimiter to make it more readable - Use text blocks - see https://docs.junit.org/current/api/org.junit.jupiter.params/org/junit/jupiter/params/provider/CsvSource.html#textBlock() (instead of multiple strings)
- Use
#as comment sign --> See https://docs.junit.org/current/api/org.junit.jupiter.params/org/junit/jupiter/params/provider/CsvSource.html#textBlock()
1 task
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Oct 23, 2025
Split Method package cleanGoogleSearchURL() : void to [package cleanGoogleSearchURLShouldReturnOriginalURL(input String) : void, package cleanGoogleSearchURLShouldReturnTargetURL(input String, expected String) : void] in class org.jabref.logic.net.URLUtilTest JabRef/jabref#14138
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Oct 23, 2025
jablib/src/test/java/org/jabref/logic/openoffice/style/OOPreFormatterTest.java There are 8 parameterized test refactorings JabRef/jabref#14138
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Oct 23, 2025
jablib/src/test/java/org/jabref/logic/openoffice/style/OOPreFormatterTest.java There are 8 parameterized test refactorings JabRef/jabref#14138 This changes generates LeafExpression mappings for the tests with a single statement removeBraces() equations() formatStripLatexCommands()
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Oct 23, 2025
jablib/src/test/java/org/jabref/logic/openoffice/style/OOPreFormatterTest.java There are 8 parameterized test refactorings JabRef/jabref#14138 This change generates LeafExpression mappings for the tests with a single statement removeBraces() equations() formatStripLatexCommands()
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Oct 23, 2025
jablib/src/test/java/org/jabref/logic/openoffice/style/OOPreFormatterTest.java There are 8 parameterized test refactorings JabRef/jabref#14138
Member
|
@zyan-repository How long to you plan to work on an improvement? 😅 |
Contributor
Author
Sorry for the late reply. I had my midterms the last couple of days. I'll have the above content revised by Sunday. |
koppor
approved these changes
Oct 30, 2025
koppor
left a comment
Member
There was a problem hiding this comment.
I am not sure about the reformatting, but I want to keep things going.
Reason for not reformatting code without reason: When trying to find issues and trying out to find out where was a semantic change, purely syntactic changes are disturbing.
merlinymy
pushed a commit
to merlinymy/jabref
that referenced
this pull request
Nov 19, 2025
Co-authored-by: “zyan-repository” <“yianzhou003@gmail.com”>
victorgveloso
pushed a commit
to victorgveloso/RefactoringMiner
that referenced
this pull request
Nov 25, 2025
Split Method package cleanGoogleSearchURL() : void to [package cleanGoogleSearchURLShouldReturnOriginalURL(input String) : void, package cleanGoogleSearchURLShouldReturnTargetURL(input String, expected String) : void] in class org.jabref.logic.net.URLUtilTest JabRef/jabref#14138
victorgveloso
pushed a commit
to victorgveloso/RefactoringMiner
that referenced
this pull request
Nov 25, 2025
…ntalis#1003) jablib/src/test/java/org/jabref/logic/openoffice/style/OOPreFormatterTest.java There are 8 parameterized test refactorings JabRef/jabref#14138 This change generates LeafExpression mappings for the tests with a single statement removeBraces() equations() formatStripLatexCommands()
victorgveloso
pushed a commit
to victorgveloso/RefactoringMiner
that referenced
this pull request
Nov 25, 2025
jablib/src/test/java/org/jabref/logic/openoffice/style/OOPreFormatterTest.java There are 8 parameterized test refactorings JabRef/jabref#14138
maorethians
pushed a commit
to maorethians/RefactoringMiner
that referenced
this pull request
Jun 8, 2026
Split Method package cleanGoogleSearchURL() : void to [package cleanGoogleSearchURLShouldReturnOriginalURL(input String) : void, package cleanGoogleSearchURLShouldReturnTargetURL(input String, expected String) : void] in class org.jabref.logic.net.URLUtilTest JabRef/jabref#14138
maorethians
pushed a commit
to maorethians/RefactoringMiner
that referenced
this pull request
Jun 8, 2026
…ntalis#1003) jablib/src/test/java/org/jabref/logic/openoffice/style/OOPreFormatterTest.java There are 8 parameterized test refactorings JabRef/jabref#14138 This change generates LeafExpression mappings for the tests with a single statement removeBraces() equations() formatStripLatexCommands()
maorethians
pushed a commit
to maorethians/RefactoringMiner
that referenced
this pull request
Jun 8, 2026
jablib/src/test/java/org/jabref/logic/openoffice/style/OOPreFormatterTest.java There are 8 parameterized test refactorings JabRef/jabref#14138
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs JabRef#676
This pull request parameterizes the existing JUnit 5 tests for the LayoutTest class, URLUtilTest class, OOPreFormatterTest class, RemoteUtilTest class, DefaultTexParserTest class, ISBNTest class and ISSNTest class. This change allows multiple inputs and expected outputs to be tested with the same test logic, which improves code readability and makes it easier to add more test cases in the future. Other PRs from classmates addressing this same issue will follow shortly to complete the task(@espertusnu ).
Steps to test
Execute the Filtered Test Command
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)