Skip to content

fix: prevent Windows tempdir deletion failure#14102

Merged
Siedlerchr merged 2 commits into
JabRef:mainfrom
wanling0000:fix/test-cleanup-mergebookkeeper-windows
Oct 17, 2025
Merged

fix: prevent Windows tempdir deletion failure#14102
Siedlerchr merged 2 commits into
JabRef:mainfrom
wanling0000:fix/test-cleanup-mergebookkeeper-windows

Conversation

@wanling0000

@wanling0000 wanling0000 commented Oct 17, 2025

Copy link
Copy Markdown
Collaborator

Closes #12350

This PR fixes a Windows test cleanup issue that was reported by @Siedlerchr in our group chat.
Adds RepositoryCache.clear() and WindowCache.reconfigure(...) in MergeBookkeeperTest to the test teardown.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@wanling0000 wanling0000 marked this pull request as draft October 17, 2025 17:22
@wanling0000 wanling0000 reopened this Oct 17, 2025
@wanling0000 wanling0000 marked this pull request as ready for review October 17, 2025 21:45
@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 17, 2025
@Siedlerchr

Copy link
Copy Markdown
Member

Thanks for the quick fix! Will check later if the main passes all checks.

Merged via the queue into JabRef:main with commit 4fd2ed0 Oct 17, 2025
48 checks passed
merlinymy pushed a commit to merlinymy/jabref that referenced this pull request Nov 19, 2025
* fix: prevent Windows tempdir deletion failure

* fix: reformat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add (simple) git support

2 participants