Skip to content

Prevent spaces in custom entry#14091

Merged
calixtus merged 5 commits into
JabRef:mainfrom
am167:prevent-spaces-custom-entry
Oct 14, 2025
Merged

Prevent spaces in custom entry#14091
calixtus merged 5 commits into
JabRef:mainfrom
am167:prevent-spaces-custom-entry

Conversation

@am167

@am167 am167 commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

Closes #14088

This PR addresses #14088 by adding an additional check on the validator to ensure the input does not contain spaces.

Steps to test

  1. Start JabRef
  2. Open preferences
  3. Open 'Entry Types'
  4. Attempt to create a custom entry type with a name containing a space
  5. Observe system preventing the creation of the entry type

Before:
image
After:
image

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • I added screenshots in the PR description (if change is visible to the user)
  • I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@am167

am167 commented Oct 14, 2025

Copy link
Copy Markdown
Contributor Author

Seems like something is wrong with the automatic tests
image
Can we please re-run the tests?

@calixtus calixtus changed the title #14088 Prevent spaces custom entry Prevent spaces in custom entry Oct 14, 2025
@calixtus

Copy link
Copy Markdown
Member

Seems like something is wrong with the automatic tests ...

Looks like a a hickup to me. All tests are green. Looks good to me! Thanks!

@calixtus calixtus added this pull request to the merge queue Oct 14, 2025
Merged via the queue into JabRef:main with commit b873a78 Oct 14, 2025
55 checks passed
merlinymy pushed a commit to merlinymy/jabref that referenced this pull request Nov 19, 2025
* JabRef#14088 prevent custom entry types with spaces

* JabRef#14088 update changelog

* JabRef#14088 resolve LocalizationConsistencyTest

* try rerun automated tests

* remove trailing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent custom entry types with spaces

2 participants