Skip to content

Implement fulltext and search based fetcher for EuropePMC#14079

Merged
Siedlerchr merged 8 commits into
mainfrom
europubmed
Oct 12, 2025
Merged

Implement fulltext and search based fetcher for EuropePMC#14079
Siedlerchr merged 8 commits into
mainfrom
europubmed

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Oct 12, 2025

Copy link
Copy Markdown
Member

Closes #13400

Steps to test

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 12, 2025
subhramit
subhramit reviewed Oct 12, 2025
View reviewed changes

@subhramit subhramit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions

Comment thread jablib/src/main/java/org/jabref/logic/importer/fetcher/EuropePmcFetcher.java Outdated
Comment thread jablib/src/main/java/org/jabref/logic/importer/fetcher/EuropePmcFetcher.java Outdated
Comment thread jablib/src/main/java/org/jabref/logic/importer/fetcher/EuropePmcFetcher.java Outdated
Comment thread jablib/src/main/java/org/jabref/logic/importer/fetcher/EuropePmcFetcher.java Outdated
Comment thread jablib/src/main/java/org/jabref/logic/importer/fetcher/EuropePmcFetcher.java Outdated
Comment thread jablib/src/main/java/org/jabref/logic/importer/fetcher/EuropePmcFetcher.java Outdated
@subhramit subhramit added status: awaiting-second-review For non-trivial changes component: fetcher and removed status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Oct 12, 2025
Siedlerchr and others added 5 commits October 12, 2025 22:11
@Siedlerchr @subhramit
Update jablib/src/main/java/org/jabref/logic/importer/fetcher/EuropeP…
f12a8a5 
…mcFetcher.java

Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
@Siedlerchr @subhramit
Update jablib/src/main/java/org/jabref/logic/importer/fetcher/EuropeP…
67fb6fb 
…mcFetcher.java

Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
@Siedlerchr @subhramit
Update jablib/src/main/java/org/jabref/logic/importer/fetcher/EuropeP…
6dbe231 
…mcFetcher.java

Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
@Siedlerchr
apply suggestions
f88203e
@subhramit
Fix failing SLR tests & extract date pattern constant
9c4fb4e
@Siedlerchr

Siedlerchr commented Oct 12, 2025

Copy link
Copy Markdown
Member Author

thanks for the SLR!°

@Siedlerchr Siedlerchr enabled auto-merge October 12, 2025 21:51
@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 12, 2025
Merged via the queue into main with commit d9b90c6 Oct 12, 2025
52 checks passed
@Siedlerchr Siedlerchr deleted the europubmed branch October 12, 2025 22:18
@github-actions github-actions Bot mentioned this pull request Oct 12, 2025
Closed
Shanaya-1981 pushed a commit to Shanaya-1981/jabref that referenced this pull request Oct 13, 2025
@Siedlerchr @subhramit @Shanaya-1981
Implement fulltext and search based fetcher for EuropePMC (JabRef#14079)
4fd0b61 
* add fulltext

* Implement search based fetcher as well

* Implement search based fetcher as well

* Update jablib/src/main/java/org/jabref/logic/importer/fetcher/EuropePmcFetcher.java

Co-authored-by: Subhramit Basu <subhramit.bb@live.in>

* Update jablib/src/main/java/org/jabref/logic/importer/fetcher/EuropePmcFetcher.java

Co-authored-by: Subhramit Basu <subhramit.bb@live.in>

* Update jablib/src/main/java/org/jabref/logic/importer/fetcher/EuropePmcFetcher.java

Co-authored-by: Subhramit Basu <subhramit.bb@live.in>

* apply suggestions

* Fix failing SLR tests & extract date pattern constant

---------

Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
merlinymy pushed a commit to merlinymy/jabref that referenced this pull request Nov 19, 2025
@Siedlerchr @subhramit @merlinymy
Implement fulltext and search based fetcher for EuropePMC (JabRef#14079)
120b7bf 
* add fulltext

* Implement search based fetcher as well

* Implement search based fetcher as well

* Update jablib/src/main/java/org/jabref/logic/importer/fetcher/EuropePmcFetcher.java

Co-authored-by: Subhramit Basu <subhramit.bb@live.in>

* Update jablib/src/main/java/org/jabref/logic/importer/fetcher/EuropePmcFetcher.java

Co-authored-by: Subhramit Basu <subhramit.bb@live.in>

* Update jablib/src/main/java/org/jabref/logic/importer/fetcher/EuropePmcFetcher.java

Co-authored-by: Subhramit Basu <subhramit.bb@live.in>

* apply suggestions

* Fix failing SLR tests & extract date pattern constant

---------

Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@subhramit subhramit subhramit approved these changes

Assignees

No one assigned

Labels

component: fetcher status: awaiting-second-review For non-trivial changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extend Europe/PMC Fetcher with fulltxext and more types

2 participants

@Siedlerchr @subhramit