Fix search query reset issue after entry deletion#14063
Merged
Conversation
- Add EntriesRemovedEvent listener to MainTableDataModel.SearchIndexListener - Refresh search matches when entries are removed to prevent stale entries - Ensure filtered list is properly updated after entry deletion - Maintain search query state during entry manipulation operations This fixes the issue where search results would show stale entries after deleting entries from search results, making it appear as if the search query was reset even though it remained in the search bar.
Contributor
Hey @P1terW!Thank you for contributing to JabRef! Your help is truly appreciated ❤️. We have automatic checks in place, based on which you will soon get automated feedback if any of them are failing. We also use TragBot with custom rules that scans your changes and provides some preliminary comments, before a maintainer takes a look. TragBot is still learning, and may not always be accurate. In the "Files changed" tab, you can go through its comments and just click on "Resolve conversation" if you are sure that it is incorrect, or comment on the conversation if you are doubtful. Please re-check our contribution guide in case of any other doubts related to our contribution workflow. |
- Move EntriesRemovedEvent import to correct alphabetical position - Fixes checkstyle ImportOrder violation
Contributor
Author
|
Before: |
Siedlerchr
previously approved these changes
Oct 10, 2025
calixtus
approved these changes
Oct 10, 2025
Siedlerchr
approved these changes
Oct 10, 2025
Shanaya-1981
pushed a commit
to Shanaya-1981/jabref
that referenced
this pull request
Oct 13, 2025
* Fix search query reset issue after entry deletion - Add EntriesRemovedEvent listener to MainTableDataModel.SearchIndexListener - Refresh search matches when entries are removed to prevent stale entries - Ensure filtered list is properly updated after entry deletion - Maintain search query state during entry manipulation operations This fixes the issue where search results would show stale entries after deleting entries from search results, making it appear as if the search query was reset even though it remained in the search bar. * Fix import order for EntriesRemovedEvent - Move EntriesRemovedEvent import to correct alphabetical position - Fixes checkstyle ImportOrder violation * Update CHANGELOG with fixed issue description and link --------- Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
merlinymy
pushed a commit
to merlinymy/jabref
that referenced
this pull request
Nov 19, 2025
* Fix search query reset issue after entry deletion - Add EntriesRemovedEvent listener to MainTableDataModel.SearchIndexListener - Refresh search matches when entries are removed to prevent stale entries - Ensure filtered list is properly updated after entry deletion - Maintain search query state during entry manipulation operations This fixes the issue where search results would show stale entries after deleting entries from search results, making it appear as if the search query was reset even though it remained in the search bar. * Fix import order for EntriesRemovedEvent - Move EntriesRemovedEvent import to correct alphabetical position - Fixes checkstyle ImportOrder violation * Update CHANGELOG with fixed issue description and link --------- Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13984
This PR fixes the issue where search results would show stale entries after deleting entries from search results, making it appear as if the search query was reset even though it remained in the search bar.
Added an
EntriesRemovedEventlistener toMainTableDataModel.SearchIndexListenerthat refreshes search matches when entries are removed from the database, ensuring the filtered list is properly updated to prevent stale entries and maintain the search query state during entry manipulation operations.Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)