Skip to content

#14058 Fix alphabetical ordering in dropdown#14060

Merged
Siedlerchr merged 8 commits into
JabRef:mainfrom
am167:main
Oct 10, 2025
Merged

#14058 Fix alphabetical ordering in dropdown#14060
Siedlerchr merged 8 commits into
JabRef:mainfrom
am167:main

Conversation

@am167

@am167 am167 commented Oct 10, 2025

Copy link
Copy Markdown
Contributor

Closes #14058

This PR fixes #14058 by sorting the APPLICATION list alphabetically.
I have made the decision to sort the whole list rather than just reorder how applications are inserted into the GUI. Personally I think this is better but happy to revert back to just changing the order of the list.

Steps to test

  1. Start JabRef
  2. Open preferences
  3. Go to "External programs"
  4. Open dropddown "Applications to push entries to"
  5. Observe that drop down options are displayed alphabetically ascending
image

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • I added screenshots in the PR description (if change is visible to the user)
  • I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@github-actions

github-actions Bot commented Oct 10, 2025

Copy link
Copy Markdown
Contributor

Hey @am167!

Thank you for contributing to JabRef! Your help is truly appreciated ❤️.

We have automatic checks in place, based on which you will soon get automated feedback if any of them are failing.
We also use TragBot with custom rules that scans your changes and provides some preliminary comments, before a maintainer takes a look.
TragBot is still learning, and may not always be accurate.
In the "Files changed" tab, you can go through its comments and just click on "Resolve conversation" if you are sure that it is incorrect, or comment on the conversation if you are doubtful.

Please re-check our contribution guide in case of any other doubts related to our contribution workflow.

Siedlerchr
Siedlerchr previously approved these changes Oct 10, 2025
View reviewed changes
@am167

am167 commented Oct 10, 2025

Copy link
Copy Markdown
Contributor Author

Do I need to make a new PR to resolve Source branch is other than "main" (pull_request)?

@Siedlerchr

Siedlerchr commented Oct 10, 2025

Copy link
Copy Markdown
Member

For the text time please create a new branch but this is okay now.

@am167

am167 commented Oct 10, 2025

Copy link
Copy Markdown
Contributor Author

Understood, thanks

koppor
koppor previously requested changes Oct 10, 2025
View reviewed changes
Comment thread jabgui/src/main/java/org/jabref/gui/push/GuiPushToApplications.java Outdated
@koppor koppor mentioned this pull request Oct 10, 2025
Merged
1 task
@jabref-machine

jabref-machine commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator

You committed your code on the main brach of your fork. This is a bad practice. The right way is to branch out from main, work on your patch/feature in that new branch, and then get that branch merged via the pull request (see GitHub flow).

For this pull request, this is OK. For subsequent pull requests, please start with a different branch with a proper branch name. See CONTRIBUTING.md for more details.

@am167 am167 requested a review from koppor October 10, 2025 10:37
@Siedlerchr Siedlerchr enabled auto-merge October 10, 2025 10:43
@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 10, 2025
Merged via the queue into JabRef:main with commit b537055 Oct 10, 2025
49 of 50 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 10, 2025
Closed
Shanaya-1981 pushed a commit to Shanaya-1981/jabref that referenced this pull request Oct 13, 2025
@am167 @Shanaya-1981
JabRef#14058 Fix alphabetical ordering in dropdown (JabRef#14060)
04c0cd7 
* JabRef#14058 - fix alphabetical ordering

* JabRef#14058 - update change log

* JabRef#14058 feedback - reorder
merlinymy pushed a commit to merlinymy/jabref that referenced this pull request Nov 19, 2025
@am167 @merlinymy
JabRef#14058 Fix alphabetical ordering in dropdown (JabRef#14060)
60a1454 
* JabRef#14058 - fix alphabetical ordering

* JabRef#14058 - update change log

* JabRef#14058 feedback - reorder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@subhramit subhramit subhramit approved these changes

@koppor koppor Awaiting requested review from koppor

Assignees

No one assigned

Labels

first contrib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix alphabetical ordering in dropdown.

5 participants

@am167 @Siedlerchr @jabref-machine @koppor @subhramit