Skip to content

Changed ComboBox to SearchableComboBox in FieldFormatterCleanupsPanel#14031

Merged
calixtus merged 8 commits into
JabRef:mainfrom
bhrhmn:fix-for-issue-13890
Oct 9, 2025
Merged

Changed ComboBox to SearchableComboBox in FieldFormatterCleanupsPanel#14031
calixtus merged 8 commits into
JabRef:mainfrom
bhrhmn:fix-for-issue-13890

Conversation

@bhrhmn

@bhrhmn bhrhmn commented Oct 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #13890

Changed type of addableFields and addableFormatters to SeachableComboBox in FieldFormatterCleanupsPanel.

Steps to test

  1. Open a library or new example library.
  2. Go to Quality -> Clean up entries.
  3. Check Enable field formatters.
  4. Write "title" in the left combobox.
    It will now show only the fields containing the string "title". The same will be true for the right combobox as well.
image Screenshot From 2025-10-09 15-52-36

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • I added screenshots in the PR description (if change is visible to the user)
  • I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@github-actions

github-actions Bot commented Oct 5, 2025

Copy link
Copy Markdown
Contributor

Hey @bhrhmn!

Thank you for contributing to JabRef! Your help is truly appreciated ❤️.

We have automatic checks in place, based on which you will soon get automated feedback if any of them are failing.
We also use TragBot with custom rules that scans your changes and provides some preliminary comments, before a maintainer takes a look.
TragBot is still learning, and may not always be accurate.
In the "Files changed" tab, you can go through its comments and just click on "Resolve conversation" if you are sure that it is incorrect, or comment on the conversation if you are doubtful.

Please re-check our contribution guide in case of any other doubts related to our contribution workflow.

@Siedlerchr

Siedlerchr commented Oct 5, 2025

Copy link
Copy Markdown
Member

In the fxml you probably need to add the import to the top as well

@Siedlerchr

Siedlerchr commented Oct 7, 2025

Copy link
Copy Markdown
Member

@bhrhmn Are you continuing here?

@bhrhmn

bhrhmn commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

Yes I will work on it this week. I did add the import for searchableComboBox at the top of the fxml file but when I run the program, my changes to the fxml file disappear. Is it something I am missing?

@bhrhmn

bhrhmn commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

Nevermind I have been trying to write in the build files. I think I got it to work so I will do a new pr

@Siedlerchr

Siedlerchr commented Oct 9, 2025

Copy link
Copy Markdown
Member

Why did you rever the latest changes?

@bhrhmn

bhrhmn commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

I saw that I had pushed some changes to csl-locales and csl-styles which I thought was weird so I wanted to revert and only push the changes to FieldFormatterCleanupsPanel.fxml.

@Siedlerchr

Siedlerchr commented Oct 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Ah we have a how to on that https://devdocs.jabref.org/code-howtos/faq.html#submodules

@bhrhmn bhrhmn marked this pull request as ready for review October 9, 2025 15:37
@calixtus
Revise CHANGELOG for recent updates and fixes
ea855ab 
Updated CHANGELOG with new features, changes, fixes, and removals.
@calixtus

calixtus commented Oct 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Took the opportunity to alter the changelog entry a little bit. Imho this is an addition, not a fix.
Looks good to me. Approved and put on merge queue. Thank you for your efforts. Feel free to push follow-up prs with other comboboxes or to pick another issue.

@calixtus calixtus enabled auto-merge October 9, 2025 23:16
@calixtus calixtus added this pull request to the merge queue Oct 9, 2025
Merged via the queue into JabRef:main with commit aa9f553 Oct 9, 2025
49 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 9, 2025
Closed
2 tasks
Shanaya-1981 pushed a commit to Shanaya-1981/jabref that referenced this pull request Oct 13, 2025
@bhrhmn @calixtus @Shanaya-1981
Changed ComboBox to SearchableComboBox in FieldFormatterCleanupsPanel (…
cf1b416 
…JabRef#14031)

* Changed ComboBox to SearchableComboBox in FieldFormatterCleanupsPanel

* Changed the combobox to a searchable combobox

* Revert "Changed the combobox to a searchable combobox"

This reverts commit 348762b.

* changed combobox to a searchable combobox

* Added bugfix to CHANGELOG.md

* Corrected an issue number in CHANGELOG.md

* Revise CHANGELOG for recent updates and fixes

Updated CHANGELOG with new features, changes, fixes, and removals.

---------

Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
This was referenced Oct 13, 2025
Closed
Closed
Closed
merlinymy pushed a commit to merlinymy/jabref that referenced this pull request Nov 19, 2025
@bhrhmn @calixtus @merlinymy
Changed ComboBox to SearchableComboBox in FieldFormatterCleanupsPanel (…
fdd8dcf 
…JabRef#14031)

* Changed ComboBox to SearchableComboBox in FieldFormatterCleanupsPanel

* Changed the combobox to a searchable combobox

* Revert "Changed the combobox to a searchable combobox"

This reverts commit 348762b.

* changed combobox to a searchable combobox

* Added bugfix to CHANGELOG.md

* Corrected an issue number in CHANGELOG.md

* Revise CHANGELOG for recent updates and fixes

Updated CHANGELOG with new features, changes, fixes, and removals.

---------

Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

component: ui first contrib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Field finder combobox doesn't work in "Clean up" dialog

4 participants

@bhrhmn @Siedlerchr @calixtus @koppor