Skip to content

Share .idea/codeStyles/Project.xml#13913

Merged
koppor merged 4 commits into
mainfrom
better-place-format-config
Sep 15, 2025
Merged

Share .idea/codeStyles/Project.xml#13913
koppor merged 4 commits into
mainfrom
better-place-format-config

Conversation

@koppor

@koppor koppor commented Sep 15, 2025

Copy link
Copy Markdown
Member

Follow-up to #13900

I read about sharing IDE config at https://stackoverflow.com/a/9092648/873282 and https://www.jetbrains.com/help/idea/configure-project-settings.html#share-project-through-vcs

This implements sharing using git.

Benefit:

  • Users immediately have the code style activated
  • Changes in the config - are directly persisted in git and can shared easily.
  • Supported by IntelliJ

Note: The filename Project.xml is hard coded.

Other options:

Steps to test

  1. Checkout the branch
  2. Restart IntelliJ using cache invalidation
  3. Modify something in the code style
  4. git diff should show a change in .idea/codeStyles/Project.xml

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@koppor koppor requested a review from Yubo-Cao September 15, 2025 11:50
@trag-bot

trag-bot Bot commented Sep 15, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@koppor

koppor commented Sep 15, 2025

Copy link
Copy Markdown
Member Author

Should go in. If we have some issues, we can fix later.

Maybe, contributors will have to invalidate caches of IntelliJ.

@koppor koppor added dev: code-quality Issues related to code or architecture decisions automerge PR is tagged with that label will be merged if workflows are green labels Sep 15, 2025
@koppor koppor enabled auto-merge September 15, 2025 14:33
@koppor koppor added this pull request to the merge queue Sep 15, 2025
Merged via the queue into main with commit f3d0081 Sep 15, 2025
51 of 60 checks passed
@koppor koppor deleted the better-place-format-config branch September 15, 2025 15:00
@koppor koppor mentioned this pull request Sep 17, 2025
1 task
Siedlerchr added a commit that referenced this pull request Sep 17, 2025
* upstream/main:
  Refine .gitginore (#13931)
  Hotfix: Markdown lint issue
  Update custom code style decision document
  Chore(deps): Bump org.openrewrite.rewrite from 7.15.0 to 7.16.0 (#13923)
  New translations jabref_en.properties (French) (#13928)
  Chore(deps): Bump com.fasterxml.jackson.dataformat:jackson-dataformat-yaml (#13927)
  Chore(deps): Bump com.autonomousapps:dependency-analysis-gradle-plugin (#13924)
  Chore(deps): Bump com.autonomousapps:dependency-analysis-gradle-plugin (#13921)
  Chore(deps): Bump org.yaml:snakeyaml from 2.4 to 2.5 in /versions (#13922)
  Chore(deps): Bump tj-actions/changed-files from 45 to 47 (#13917)
  Chore(deps): Bump plbstl/first-contribution from 3 to 4 (#13916)
  Share .idea/codeStyles/Project.xml (#13913)
  Chore(deps): Bump actions/github-script from 7 to 8 (#13915)
  Chore(deps): Bump jbangdev/jbang-action from 0.129.0 to 0.130.0 (#13914)
@calixtus calixtus mentioned this pull request Sep 24, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge PR is tagged with that label will be merged if workflows are green dev: code-quality Issues related to code or architecture decisions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants