Remove wrong assert statement#13906
Merged
Merged
Conversation
| assert entries != null; | ||
| assert entries.size() != 1; // Either there is no entry with different fields or more than one | ||
| if (entries == null || entries.size() <= 1 || differingFields.isEmpty()) { | ||
| // entries.size == 1 can happen if there is only one entry for one type. (E.g., only one `@Book` entry) |
There was a problem hiding this comment.
The comment is trivial and restates the obvious logic of the code. Comments should provide new insights or reasoning, not describe what the code already clearly does.
Siedlerchr
approved these changes
Sep 14, 2025
Siedlerchr
added a commit
that referenced
this pull request
Sep 17, 2025
* upstream/main: Add new check for format (#13909) Consistent casing in fieldnames (#13867) Revert "Pressing TAB in last field in entry editor moves focus to the next ta…" (#13912) Fix YAML Fix on-pr-opened-updated.yml syntax Pressing TAB in last field in entry editor moves focus to the next tab's first field (#13870) Modularize JabSrv (#13908) New translations jabref_en.properties (Italian) (#13907) Remove wrong `assert` statement (#13906) Add .git-blame-ignore-revs (#13884) Do not show transprot info messages (#13904) Pubmed api key support (#13899) Fix warnings for native access Fix automerge workflow (#13903) Add comment on issue on binary (#13902) Have checkstyle and VCS configuration distributed (#13900) Add unknown field to lsp consistency check (#13880) Put config for general tab if missing (#13901) Fix autosave manager exception on shutdown (#13882)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had dozens of exceptions while running LSP:
Steps to test
@BookentryMandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)