Skip to content

Observable Preferences Y (Resetting preferences)#13894

Merged
koppor merged 16 commits into
mainfrom
fix-prefs
Nov 20, 2025
Merged

Observable Preferences Y (Resetting preferences)#13894
koppor merged 16 commits into
mainfrom
fix-prefs

Conversation

@calixtus

@calixtus calixtus commented Sep 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Refs #12655 (Importing into a present, observable and mutable preferences object)

Refs #10177 (Cleaning up dependencies to prefs)
Refs #12990 (Cleaning up JabRefGuiPreferences / JabRefCliPreferences
Follow up to #10002

Steps to test

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] I manually tested my changes in running JabRef (always required)
  • [.] I added JUnit tests for changes (if applicable)
  • [.] I added screenshots in the PR description (if change is visible to the user)
  • [.] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [.] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@calixtus calixtus self-assigned this Sep 13, 2025
@calixtus calixtus added dev: code-quality Issues related to code or architecture decisions component: preferences labels Sep 13, 2025
@koppor

koppor commented Sep 14, 2025

Copy link
Copy Markdown
Member

Related (because language dependent): #13901

@koppor koppor mentioned this pull request Sep 14, 2025
Closed
2 tasks
@trag-bot

trag-bot Bot commented Sep 18, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor added the status: changes-required Pull requests that are not yet complete label Nov 20, 2025
@calixtus
Add comments
fe9ae6f
@calixtus
Add import
f76113f
@calixtus
Merge remote-tracking branch 'upstream/main' into fix-prefs
b6f773c 
# Conflicts:
#	jabgui/src/main/java/org/jabref/gui/preferences/general/GeneralTab.java
#	jabgui/src/main/java/org/jabref/gui/preferences/general/GeneralTabViewModel.java
@calixtus
Apply merge conflict fixes
3d5c787
@github-actions github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Nov 20, 2025
@koppor

koppor commented Nov 20, 2025

Copy link
Copy Markdown
Member

Prototype for workspace preferences - needs to be continued for the other preferences.

We prepared the UI under the assumption that the adaption will be done soon.

@koppor

koppor commented Nov 20, 2025

Copy link
Copy Markdown
Member

Strange that following string still apperas:

- "You must restart JabRef for this to come into effect."

@koppor koppor marked this pull request as ready for review November 20, 2025 14:02
@calixtus

calixtus commented Nov 20, 2025

Copy link
Copy Markdown
Member Author

Strange that following string still apperas:

- "You must restart JabRef for this to come into effect."

Fixed. Was about a duplicated property in WorkspacePreferences that was removed.

@koppor koppor mentioned this pull request Nov 20, 2025
Open
2 tasks
@koppor

koppor commented Nov 20, 2025

Copy link
Copy Markdown
Member

No CHANGELOG.md yet, because issue #12655 not fixed.

The behavior of removing the warning message is too little.

@koppor koppor enabled auto-merge November 20, 2025 14:20
@koppor koppor added this pull request to the merge queue Nov 20, 2025
@calixtus

calixtus commented Nov 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Working pattern for followup PRs:
In JabRefGui/CliPreferences remove
grafik

In XXXPreferences class

  • Add private default constructor
grafik
  • Add getDefault method
grafik
  • Add setAll method
grafik

In JabRefGui/CliPreferences class

  • Add fromBackingStore method
grafik
  • Modify getXXXPreferences method
grafik
  • Add to clear / importPreferences method
grafik

calixtus
calixtus commented Nov 20, 2025
View reviewed changes
Comment thread jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java
return workspacePreferences;
}

private WorkspacePreferences getWorkspacePreferencesFromLowLevelApi(WorkspacePreferences defaults) {

@calixtus calixtus Nov 20, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be renamed in followup to "getWorkspacePreferencesFromBackingStore"

Merged via the queue into main with commit 75d5d52 Nov 20, 2025
53 checks passed
@koppor koppor deleted the fix-prefs branch November 20, 2025 16:38
This was referenced Nov 23, 2025
Merged
Closed
@calixtus calixtus mentioned this pull request Nov 23, 2025
Merged
2 tasks
manojalluri added a commit to manojalluri/jabref that referenced this pull request Nov 27, 2025
@manojalluri
feat: Add resetting methods to MainTablePreferences Follows pattern f…
1cb6a52 
…rom PR JabRef#13894 (WorkspacePreferences) Closes JabRef#14413
@manojalluri manojalluri mentioned this pull request Nov 27, 2025
Closed
3 tasks
@shubhamk0205 shubhamk0205 mentioned this pull request Dec 3, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koppor koppor koppor approved these changes

Assignees

@calixtus calixtus

Labels

component: preferences dev: code-quality Issues related to code or architecture decisions project: jabcon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calixtus @koppor @subhramit