Skip to content

changed Keyword.of to accept List<String> instead of varargs#13871

Merged
calixtus merged 3 commits into
JabRef:mainfrom
siddhantkore:refactor-keyword-of-to-list
Sep 13, 2025
Merged

changed Keyword.of to accept List<String> instead of varargs#13871
calixtus merged 3 commits into
JabRef:mainfrom
siddhantkore:refactor-keyword-of-to-list

Conversation

@siddhantkore

@siddhantkore siddhantkore commented Sep 13, 2025

Copy link
Copy Markdown
Contributor

Closes #13602

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

calixtus
calixtus reviewed Sep 13, 2025
View reviewed changes
Comment thread CHANGELOG.md Outdated

### Changed

- We changed `Keyword.of` to accept `List<String>` instead of `varargs`.[#13602](https://github.com/JabRef/jabref/issues/13602)

@calixtus calixtus Sep 13, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entries only for user facing changes

Siedlerchr
Siedlerchr reviewed Sep 13, 2025
View reviewed changes
Comment thread CHANGELOG.md Outdated

### Changed

- We changed `Keyword.of` to accept `List<String>` instead of `varargs`.[#13602](https://github.com/JabRef/jabref/issues/13602)

@Siedlerchr Siedlerchr Sep 13, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, the changelog is user facing and this is only an internal thing

calixtus
calixtus reviewed Sep 13, 2025
View reviewed changes

@calixtus calixtus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful: Keyword.of does not create multiple Keywords or a List of Keywords, but one hierarchical one. Changes to List is in this case mostly cosmetic and using more modern java style with List safeties.

@siddhantkore

siddhantkore commented Sep 13, 2025

Copy link
Copy Markdown
Contributor Author

Hi @calixtus You right. Thanks for pointing this out and for clarification!

@trag-bot

trag-bot Bot commented Sep 13, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@calixtus calixtus added this pull request to the merge queue Sep 13, 2025
Merged via the queue into JabRef:main with commit 2d3cf9d Sep 13, 2025
34 checks passed
@github-actions github-actions Bot mentioned this pull request Sep 13, 2025
Closed
Siedlerchr added a commit that referenced this pull request Sep 13, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
4882129 
* upstream/main:
  Chronological navigation in libraries (#13863)
  Adapt code style (#13874)
  LSP Refactor to use ranges instead of string matching (#13862)
  Use jspecify (#13873)
  changed Keyword.of to accept List<String> instead of varargs (#13871)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr left review comments

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use List data structure at Keyword.of()

3 participants

@siddhantkore @Siedlerchr @calixtus