Skip to content

Fix Tagsfield in Keyword editor#13858

Merged
koppor merged 6 commits into
mainfrom
fix-keywords
Sep 11, 2025
Merged

Fix Tagsfield in Keyword editor#13858
koppor merged 6 commits into
mainfrom
fix-keywords

Conversation

@calixtus

@calixtus calixtus commented Sep 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #11390
Follow-up to #10910

The StringConverter seems only to return the parent keyword.

grafik grafik

Steps to test

In EntryEditor in source tab add hierarchichal keywords eg "parent > node > child", open general tab and see only parent in keywords, maybe with an assert exception being thrown.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • I added JUnit tests for changes (if applicable)
  • I added screenshots in the PR description (if change is visible to the user)
  • I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [.] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

trag-bot[bot]
trag-bot Bot reviewed Sep 11, 2025
View reviewed changes
Comment thread jabgui/src/test/java/org/jabref/gui/fieldeditors/KeywordsEditorViewModelTest.java
@calixtus calixtus marked this pull request as ready for review September 11, 2025 21:44
koppor
koppor reviewed Sep 11, 2025
View reviewed changes
Comment thread jabgui/src/main/java/org/jabref/gui/fieldeditors/KeywordsEditorViewModel.java Outdated
@trag-bot

trag-bot Bot commented Sep 11, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor enabled auto-merge September 11, 2025 22:20
@koppor koppor added this pull request to the merge queue Sep 11, 2025
Merged via the queue into main with commit ecd271a Sep 11, 2025
42 of 49 checks passed
@koppor koppor deleted the fix-keywords branch September 11, 2025 22:44
@github-actions github-actions Bot mentioned this pull request Sep 11, 2025
Closed
Siedlerchr added a commit that referenced this pull request Sep 12, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into sbom
dcfb243 
* upstream/main:
  Fix Tagsfield in Keyword editor (#13858)
Siedlerchr added a commit that referenced this pull request Sep 13, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
87abac1 
* upstream/main:
  New Crowdin updates (#13865)
  Fix unresponsive "Check Consistency" dialog (#13864)
  Fix several aux group issues (#13861)
  Add integrity check to cli (#13848)
  Add sbom file and remove external libraries (#13859)
  Fix Tagsfield in Keyword editor (#13858)
  Chore(deps): Bump jablib/src/main/resources/csl-styles (#13857)
  Chore(deps): Bump jablib/src/main/resources/csl-locales (#13856)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trag-bot trag-bot[bot] trag-bot[bot] left review comments

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@koppor koppor koppor approved these changes

Assignees

No one assigned

Labels

project: jabcon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The new tag system ignores hierarchical keywords. Only the parent keyword is shown.

3 participants

@calixtus @Siedlerchr @koppor