Skip to content

fix: Improper icon sizing with respect to font size#13841

Merged
Siedlerchr merged 1 commit into
JabRef:mainfrom
Yubo-Cao:main
Sep 9, 2025
Merged

fix: Improper icon sizing with respect to font size#13841
Siedlerchr merged 1 commit into
JabRef:mainfrom
Yubo-Cao:main

Conversation

@Yubo-Cao

@Yubo-Cao Yubo-Cao commented Sep 9, 2025

Copy link
Copy Markdown
Collaborator

Closes N/A

Steps to test

Open JabRef and tweak font size. Now the icon in toolbar works properly under all sort of font size.

default:
image
13pt:
image
10pt:
image

Would greatly appreciate testing from other platforms. The screenshot above is obtained from a Windows 25H2 machine.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@jabref-machine

jabref-machine commented Sep 9, 2025

Copy link
Copy Markdown
Collaborator

You committed your code on the main brach of your fork. This is a bad practice. The right way is to branch out from main, work on your patch/feature in that new branch, and then get that branch merged via the pull request (see GitHub flow).

For this pull request, this is OK. For subsequent pull requests, please start with a different branch with a proper branch name. See CONTRIBUTING.md for more details.

trag-bot[bot]
trag-bot Bot reviewed Sep 9, 2025
View reviewed changes
Comment thread jabgui/src/main/resources/org/jabref/gui/Base.css
.mainToolbar .glyph-icon,
.mainToolbar .ikonli-font-icon {
-fx-font-size: 1.7em;
/* `!important` is override library's default font size */

@trag-bot trag-bot Bot Sep 9, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment contains a grammatical error. It should be 'to override' instead of 'is override'. Comments should be properly formatted and grammatically correct.

@Siedlerchr

Siedlerchr commented Sep 9, 2025

Copy link
Copy Markdown
Member

Thanks for the quick action. Will test it later today

Siedlerchr
Siedlerchr approved these changes Sep 9, 2025
View reviewed changes

@Siedlerchr Siedlerchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks greaT!
grafik

@Siedlerchr

Siedlerchr commented Sep 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Just one thing left I think : Filter groups search bar field has a different size maybe like the half of the other
grafik

@Siedlerchr

Siedlerchr commented Sep 9, 2025

Copy link
Copy Markdown
Member

merging for now

@Siedlerchr Siedlerchr merged commit 9b13538 into JabRef:main Sep 9, 2025
36 checks passed
Siedlerchr added a commit that referenced this pull request Sep 9, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into globalSearchBar
087cc95 
* upstream/main:
  fix: Improper icon sizing with respect to font size (#13841)
  Ensure latest JDK veriant (#13843)
Siedlerchr added a commit that referenced this pull request Sep 11, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
2a819aa 
* upstream/main:
  Fix NoSuchElementException in ThreeWayMerge dialog (#13838)
  Keep global search bar open when  keep on top pin is selected (#13846)
  Spell "BibDesk" with capital "D" (#13847)
  fix: Improper icon sizing with respect to font size (#13841)
  Ensure latest JDK veriant (#13843)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trag-bot trag-bot[bot] trag-bot[bot] left review comments

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Yubo-Cao @jabref-machine @Siedlerchr