I tried using Stacked Branches in GitButler, but every time I needed to update the PR at the bottom of the stack, I had to force push the entire stack...

So finally gave up using Stacked Branches...

Review "instructions" (if someone wants to try AI)

• How are credentials stored? Is this using JabRefs credential system
• Are the language keys grouped together correctly?
• Why is "http" allowed in GitHub URLs? Shouldn't it be https only? Shouldn't that be a helpe rmethod?
• Does it work if there is already an existing GitHub connection?
• Does it work if ther eis a "giti init" made but no remote?

Review "instructions" (if someone wants to try AI)

• How are credentials stored? Is this using JabRefs credential system

Thanks for pointing this out, I did find a security issue here.

If the user chooses not to remember their GitHub credentials, we still store the username and PAT in memory (via credentialsProvider).

When the user choose to remember them, we save them in GitPreferences and use the Password class from the shared database module to encrypt and decrypt the PAT based on the username.

Do you think this is an appropriate way to handle encrypted credentials in this case? Or would you recommend a better or more standard approach within JabRef?

• How are credentials stored? Is this using JabRefs credential system
  Thanks for pointing this out, I did find a security issue here.

If the user chooses not to remember their GitHub credentials, we still store the username and PAT in memory

This is OK.

When the user choose to remember them, we save them in GitPreferences and use the Password class from the shared database module to encrypt and decrypt the PAT based on the username.

This is not good 😅

Option 1:

• In JabRef's preferences, have a store for github username and github password - similar to proxy settings (org.jabref.logic.net.ProxyPreferences)

Option 2: provider-based store

• In JabRef's preferences, have store for provider/username/password - similar to org.jabref.gui.preferences.websearch.WebSearchTabViewModel

One can store "provider" using "domain".

Use case:

Users might have

• GitHub
• GitHub enterprise (e.g., https://github.tik.uni-stuttgart.de/)
• GitLab
• Custom GitLab hostings
• CodeBerg

and much much more.

For this phase, option 1 is enough and as follow-up we can support multiple Git hosting solutions.

When entering some rubbish, JabRef freezes and becomes unresponsive. You are probably blocking the main javafx thread.

@trag-bot didn't find any issues in the code! ✅✨