Skip to content

Fix dark mode in {} of Citation Relations tab of the entry editor#13609

Merged
Siedlerchr merged 5 commits into
JabRef:mainfrom
ankamde:issue-13599-fix-darkmode-in-citation-relations-tab
Jul 30, 2025
Merged

Fix dark mode in {} of Citation Relations tab of the entry editor#13609
Siedlerchr merged 5 commits into
JabRef:mainfrom
ankamde:issue-13599-fix-darkmode-in-citation-relations-tab

Conversation

@ankamde

@ankamde ankamde commented Jul 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #13599

Fix dark mode in {} of Citation Relations tab of the entry editor.

Steps to test

  1. Switch to dark mode.
  2. Open sample entry and go to Citation Relations tab.
  3. Click on {} BibTeX source button.
image
  1. Dialog shows content of the BibTeX source in the dark mode.
image
  1. Switch back to the Light theme.
image

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr requested changes Jul 29, 2025
View reviewed changes

@Siedlerchr Siedlerchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the css defintion

Comment thread jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java Outdated

private void showEntrySourceDialog(BibEntry entry) {
CodeArea ca = new CodeArea();
TextArea area = new TextArea();

@Siedlerchr Siedlerchr Jul 29, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong approach, we use CodeArea for BibTex also in the EntryEditor and this should be used here. Instead you need to fix/add a css defintion.
See (SourceTab,)

@ankamde ankamde Jul 30, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please have a look. I hope this css definition is not to broad.

@Siedlerchr Siedlerchr added the status: changes-required Pull requests that are not yet complete label Jul 29, 2025
@ankamde ankamde requested a review from Siedlerchr July 30, 2025 15:50
@trag-bot

trag-bot Bot commented Jul 30, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed status: changes-required Pull requests that are not yet complete labels Jul 30, 2025
@Siedlerchr Siedlerchr added this pull request to the merge queue Jul 30, 2025
Merged via the queue into JabRef:main with commit 58861cf Jul 30, 2025
1 check passed
@github-actions github-actions Bot mentioned this pull request Jul 30, 2025
Closed
2 tasks
Siedlerchr added a commit that referenced this pull request Aug 2, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
8f7ffcb 
* upstream/main:
  Issue 13619 Make Citation relations text more clear. (#13620)
  Explain how to handle notifications (#13630)
  Fix scope of 'determine issue number' job (#13627)
  Add proper closing (#13626)
  Implement logic orchestration for Git Pull/Push operations (#13518)
  Make pattern for issue number more strict
  Fix "Cannot load file MultiMergeEntries.fxml" (#13624)
  Add Copy markdown to copy citation (#13387)
  Add ADR-0047 (#13621)
  Initial start of implementing a LSP for integrity checks (#13612)
  Refactor merge entries package structure (#13614)
  New Crowdin updates (#13616)
  BibEntry class no longer implements Cloneable (#13615)
  Fix dark mode in {} of Citation Relations tab of the entry editor (#13609)
  Update dependency org.kohsuke:github-api to v2.0-rc.4 (#13611)
  Fix setting of proxy without password (#13605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix darkmode in {} of Citation Relations tab of the entry editor

3 participants

@ankamde @Siedlerchr @koppor