Feat: Add select entries CAYW feature and command endpoint#13554
Merged
Conversation
…ource for executing commands through http
# Conflicts: # jabsrv/src/main/java/module-info.java # jabsrv/src/main/java/org/jabref/http/server/LibraryResource.java
subhramit
reviewed
Jul 19, 2025
calixtus
reviewed
Jul 21, 2025
calixtus
reviewed
Jul 21, 2025
… make instanceof possible
This was referenced Jul 23, 2025
koppor
requested changes
Jul 23, 2025
Comment on lines
+19
to
+21
| public ObservableList<BibDatabaseContext> getOpenDatabases() { | ||
| return FXCollections.emptyObservableList(); | ||
| } |
Member
There was a problem hiding this comment.
Follow-up: the should be a set - and org.jabref.http.server.services.ServerUtils#getBibDatabaseContext rewritten accordingly.
Here, I am a bit undecided whether a thow should be used, but maybe OK :)
| } | ||
|
|
||
| @Override | ||
| public List<String> collectAllDatabasePaths() { |
Member
There was a problem hiding this comment.
This is needed later in the project, therefore it is there?
I only see usages in the GUI currently
Maybe, its the preparation for the global search?
Member
Author
There was a problem hiding this comment.
I did put it there because I remembered there was a List of Paths for the Library Resources, I thought later on we could maybe use it to integrate it to use in filesToServe and just use this instead of filestoserve or context.
For example maybe here https://github.com/palukku/jabref/blob/561acce7864fba4023645d1d14f1ae9ebdf7bc06/jabsrv/src/main/java/org/jabref/http/server/Server.java#L76
Comment on lines
+223
to
+227
| public Optional<BibEntryTableViewModel> getViewModelByCitationKey(String citationKey) { | ||
| return entriesViewModel.stream() | ||
| .filter(viewModel -> citationKey.equals(viewModel.getEntry().getCitationKey().orElse(""))) | ||
| .findFirst(); | ||
| } |
There was a problem hiding this comment.
The method accepts a String parameter without null check, which could lead to NullPointerException. According to special instruction 19, null should never be passed to a method.
koppor
requested changes
Jul 23, 2025
|
@trag-bot didn't find any issues in the code! ✅✨ |
koppor
approved these changes
Jul 23, 2025
dcarpentiero
pushed a commit
to dcarpentiero/jabref
that referenced
this pull request
Jul 24, 2025
* add GuiHolder * remove disable wadl * refactor guibridge * replace ListChangeListener with WeakListChangeListener for garbage collection * replace ListChangeListener with WeakListChangeListener for garbage collection * refactor * add active database to guibridge * refactor selection of Entries through GuiBridge and added Command Resource for executing commands through http * update SelectEntriesCommand * add sources to jbang * fix tests * fix tests * rework StateManager * fix ServerTest * rename CliStateManager and remove extends from the GuiStateManager to make instanceof possible * remove sout * add empty returns to JabRefSrvStateManager * add CommandSelectionTab Interface * add sources to jbang * remove old comments * refine * changes requested by koppor * removed or else * change to use identity * change indent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes palukku#1 and Closes palukku#9
Added the "select=true" parameter to cayw and implemented an commands endpoint which can be used to select entries of a specific library
Steps to test
You can use the commands.http to test the selection in the chocolate.bib file.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)