Fix Intel crash in ThemeManager on macOS#13543
Conversation
- Add try/catch around themeWindowManager.install() to handle RuntimeException - Prevents crash when native libraries are incompatible with ARM64 architecture - Fixes JabRef#13536
Why is this ticked if there is no changelog entry (at least at the time of writing this)? |
| private final FileUpdateMonitor fileUpdateMonitor; | ||
| private final Consumer<Runnable> updateRunner; | ||
| private final ThemeWindowManager themeWindowManager; | ||
| private ThemeWindowManager themeWindowManager; |
There was a problem hiding this comment.
Add @Nullable; because we don't use Optionals in class variables; do we @Siedlerchr
|
Follow-up issue: dukke/FXThemes#14 |
|
I think, we have a different understanding of "Manually tested" and "fixed" If I open preferences, I get an exception:
|
|
I fixed all the issues
Since external contributors rely on the issue, I go ahead with merging. |
|
You ticked that you modified If you made changes that are visible to the user, please add a brief description along with the issue number to the |
|
@trag-bot didn't find any issues in the code! ✅✨ |
* Fix ARM64 crash in ThemeManager on macOS - Add try/catch around themeWindowManager.install() to handle RuntimeException - Prevents crash when native libraries are incompatible with ARM64 architecture - Fixes JabRef#13536 * fix try catch error * Added changelog entry * adjusted changelog entry * Added try catch also for instantiations in constructor * Delete redundant changelog entry * Removed usage of temp prefix to comply with jabref conventions * changed debug message to specify intel related issue * Fix handling of non-existing null * Fix logger output * Add mssing dots * Fix exception * Fix exception ... again ... * Fix exception ... again ... * Keep silent on intel mac when switchting dark mode does not work --------- Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Closes #13536
Changes
themeWindowManager.install(scene)in ThemeManagerTesting
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)