Skip to content

Move module tweaking of merged module to launcher#13303

Merged
calixtus merged 2 commits into
mainfrom
refine-args
Jun 11, 2025
Merged

Move module tweaking of merged module to launcher#13303
calixtus merged 2 commits into
mainfrom
refine-args

Conversation

@koppor

@koppor koppor commented Jun 11, 2025

Copy link
Copy Markdown
Member

When executing in the IDE, I get

WARNING: Unknown module: org.jabref.merged.module specified to --add-exports
WARNING: Unknown module: org.jabref.merged.module specified to --add-exports
WARNING: Unknown module: org.jabref.merged.module specified to --add-opens
WARNING: Unknown module: org.jabref.merged.module specified to --add-opens
WARNING: Unknown module: org.jabref.merged.module specified to --add-opens
WARNING: Unknown module: org.jabref.merged.module specified to --add-opens
WARNING: Unknown module: org.jabref.merged.module specified to --enable-native-access

This is correct as the merged module is created by the jlink plugin, not before.

I fixed by moving these arguments to jlink.

I am not sure if --enable-native-access can be called multiple times. Therefore, a separate commit to be able to revert if this does not work.

Steps to test

  1. Download binary
  2. Run
  3. See if InaccessibleObjectException #11198 occurs
  4. See if Total Breakdown #11188 occurs
  5. See if console / log shows something about native access warnings

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the dev: binaries Binary builds should be uploaded to builds.jabref.org label Jun 11, 2025
@trag-bot

trag-bot Bot commented Jun 11, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@github-actions

Copy link
Copy Markdown
Contributor

The build of this PR is available at https://builds.jabref.org/pull/13303/merge.

@calixtus

Copy link
Copy Markdown
Member

works on my linux machine. 👍

@calixtus calixtus added this pull request to the merge queue Jun 11, 2025
Merged via the queue into main with commit 90e5025 Jun 11, 2025
2 checks passed
@calixtus calixtus deleted the refine-args branch June 11, 2025 07:31
Siedlerchr added a commit to FlyJoanne/jabref that referenced this pull request Jun 15, 2025
* upstream/main:
  New Crowdin updates (JabRef#13330)
  Add arm 64 linux runner (JabRef#13258)
  Rename strings and variables in New Entry (JabRef#13312)
  Let consistency checker yield a return code (JabRef#13329)
  Update LETTER fragment to resolve Windows parsing issue (JabRef#13327)
  Add support for "dev: no-bot-comments"
  Update dependency org.hibernate.validator:hibernate-validator to v9.0.1.Final (JabRef#13322)
  Endnote XML Exporter: Move factory initialization to constructor (JabRef#13321)
  Refine assignment reminder (JabRef#13315)
  Add welcome message to first time contributors (JabRef#13314)
  New Crowdin updates (JabRef#13311)
  Added a setting to show File annotations' tab only when the PDF actually contains highlights or comments (JabRef#13279)
  Update dependency org.postgresql:postgresql to v42.7.7 (JabRef#13306)
  Refine PULL_REQUEST_TEMPLATE.md (JabRef#13304)
  Move module tweaking of merged module to launcher (JabRef#13303)
  Speed up gradle update (JabRef#13300)
  testImplementation is enough (JabRef#13299)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: binaries Binary builds should be uploaded to builds.jabref.org dev: build-system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants