Skip to content

Add support for Refer/BibIX import format#13118

Merged
Siedlerchr merged 7 commits into
JabRef:mainfrom
paudelritij:fix-for-issue-13069
May 19, 2025
Merged

Add support for Refer/BibIX import format#13118
Siedlerchr merged 7 commits into
JabRef:mainfrom
paudelritij:fix-for-issue-13069

Conversation

@paudelritij

@paudelritij paudelritij commented May 15, 2025

Copy link
Copy Markdown
Contributor

Closes #13069

  • 'ReferImporter' to handle refer/bibIX file format
  • Test case has been added.
  • Two example files has been added.

Notes:

  • BibIX is another variant of Refer.
  • Refer/BibIX official document seems not exists (if it please provide), I am only able to found internet documents

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Comment thread jablib/src/test/java/org/jabref/logic/importer/fileformat/ReferImporterTest.java Outdated
… case of unknown file format

- Add Refer/BibIX file in ImportFormatReaderIntegrationTest
- Update JabRef_en.properties
- Minor change to store notes for Refer/BibIX
- Minor format change in 'ReferImporterTest'
- Add CHANGELOG.md entry
@paudelritij

Copy link
Copy Markdown
Contributor Author

@Siedlerchr from integration testing I found while importing existing endnote.entries.enw which contains five entries algo choose refer/bibIX format (10 entries) so I thought it would be better to remove it from considering it as potential importer format due to it's nature of having less number of tag

@paudelritij

Copy link
Copy Markdown
Contributor Author

(my thoughts) I found standard refer/bibIX having less number of tags and different program adds their own defined tags. It might not useful to export file into refer/BibIX or if otherwise we need to have tag defined for particular field in order to develop exporter

@paudelritij paudelritij marked this pull request as ready for review May 16, 2025 12:48
Comment thread jablib/src/main/java/org/jabref/logic/importer/fileformat/ReferImporter.java Outdated
Comment thread jablib/src/test/java/org/jabref/logic/importer/fileformat/ReferImporterTest.java Outdated
Comment on lines +143 to +144
BibEntry singleBibEntry = new BibEntry(type);
singleBibEntry.setField(fieldMap);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When creating a new BibEntry object, 'withers' should be used instead of 'setField' to improve code readability and maintainability.

@trag-bot

trag-bot Bot commented May 17, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@paudelritij paudelritij requested a review from Siedlerchr May 18, 2025 09:22
@Siedlerchr

Copy link
Copy Markdown
Member

LGTM

@Siedlerchr Siedlerchr added this pull request to the merge queue May 19, 2025
Merged via the queue into JabRef:main with commit c9fca68 May 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for refer import format (similar to Endnote)

3 participants