Add support for LibreOffice's default bibliography styles by DTT12912 · Pull Request #13050 · JabRef/jabref

DTT12912 · 2025-05-02T19:59:30Z

This PR adds support for LibreOffice's default bibliography styles in JabRef's LibreOffice integration. The changes include:

Added new bibliography styles:
- "Bibliography Heading" for the bibliography section heading
- "Bibliography 1" for bibliography entries (default)
- "Text body" as an additional style option
Updated the UI:
- Renamed "Modify bibliography title" dialog to "Modify bibliography properties"
- Added a new dropdown to select bibliography body text format
- Maintained backward compatibility with existing styles
Backend changes:
- Added new styles to CSLFormatUtils.Format enum
- Updated OpenOfficePreferences to store bibliography body format
- Modified CSLCitationOOAdapter to use the selected body format

These changes ensure that JabRef uses LibreOffice's default bibliography styles by default while still allowing users to choose alternative styles if desired.

Mandatory checks

[] I own the copyright of the code submitted and I license it under the MIT license
[] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
[] Tests created for changes (if applicable)
[] Manually tested changed features in running JabRef (always required)
[] Screenshots added in PR description (if change is visible to the user)
[] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
[] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

subhramit · 2025-05-02T20:07:22Z

+        HEADING_4("Heading 4"),
+        BIBLIOGRAPHY_HEADING("Bibliography Heading"),
+        BIBLIOGRAPHY_1("Bibliography 1"),
+        TEXT_BODY("Text body");


Did you read the issue properly? Did you understand the difference between formatting of the bibliography header and the bibliography text?

subhramit · 2025-05-02T20:18:41Z

The PR is blindly copy-pasted (or AI-adapted) without manual testing, screenshots, proper preference settings, etc.
Tests are also failing.
Please go through the existing code again, try to understand it, make changes, test and mark ready for review once done.
Ask questions if you encounter any.
If the PR is at a ready for review state without proper understanding, I will be closing it (and you can work on simpler issues).

subhramit · 2025-05-02T20:30:26Z

Also do not mark the mandatory checks blindly. We expect sincerity from contributors - read what you are marking as "done".

DTT12912 · 2025-05-02T20:34:20Z

Hi @subhramit Thank you for looking into the PR. I totally understand your frustration. Right now I'm just trying to figure out about the project . I will ping you if I have any questions or once I take the PR out of draft

subhramit · 2025-05-02T20:55:27Z

Hi @subhramit Thank you for looking into the PR. I totally understand your frustration. Right now I'm just trying to figure out about the project . I will ping you if I have any questions or once I take the PR out of draft

Since you are probably a beginner, here are some more hints about the things that are missing:

The root preference declaration and default setting should go into JabRefCliPreferences (you can find the corresponding code in the linked PR in the issue).
The paragraph formatting for the title of the bibliography and the body will be separate. To understand this, try out the libreoffice integration. You can check out this as well as this. This will also help you test your changes.

…into fix-issue-13049

trag-bot · 2025-05-02T21:49:56Z

@trag-bot didn't find any issues in the code! ✅✨

jabref-machine · 2025-05-02T21:57:23Z

Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of [x] (done), [ ] (not done yet) or [/] (not applicable).

Co-authored-by: DTT12912 <derictonythomas@gmail.com> Co-authored-by: subhramit <subhramit.bb@live.in> Signed-off-by: subhramit <subhramit.bb@live.in>

subhramit · 2025-05-07T11:52:26Z

Hi @DTT12912
I am closing this PR as a lot of surrounding changes also had to be made which were difficult to instruct and iteratively review, not making suitable for beginners. I have added you as a co-author to commit 589900f and built upon your changes here - you can check it out to learn from the corrected solution.

Thank you for your efforts!

* Introduce bibliography body formats (fix code from #13050) Co-authored-by: DTT12912 <derictonythomas@gmail.com> Co-authored-by: subhramit <subhramit.bb@live.in> Signed-off-by: subhramit <subhramit.bb@live.in> * Get hanging indent working Signed-off-by: subhramit <subhramit.bb@live.in> * Remove redundant AI comment Signed-off-by: subhramit <subhramit.bb@live.in> * Fix JabRef formatting infra Signed-off-by: subhramit <subhramit.bb@live.in> * Remove redundant comment Signed-off-by: subhramit <subhramit.bb@live.in> * Temp commit Signed-off-by: subhramit <subhramit.bb@live.in> * Revert "Temp commit" This reverts commit 1174ca0. * Remove unused constant Signed-off-by: subhramit <subhramit.bb@live.in> * Rename adapter, remove redundant comment Signed-off-by: subhramit <subhramit.bb@live.in> * Remove commented code Signed-off-by: subhramit <subhramit.bb@live.in> * Swap order of conditions Signed-off-by: subhramit <subhramit.bb@live.in> * wip Signed-off-by: subhramit <subhramit.bb@live.in> * wip Signed-off-by: subhramit <subhramit.bb@live.in> * Selective override of preferences Signed-off-by: subhramit <subhramit.bb@live.in> * Use list instead of enum Signed-off-by: subhramit <subhramit.bb@live.in> * Rename variables Signed-off-by: subhramit <subhramit.bb@live.in> * Rename with lambda Signed-off-by: subhramit <subhramit.bb@live.in> * Add setters Signed-off-by: subhramit <subhramit.bb@live.in> * Fix bindings introduced in #12784 Signed-off-by: subhramit <subhramit.bb@live.in> * Simplify button logic Signed-off-by: subhramit <subhramit.bb@live.in> * Shift to OO Panel, complete pref behavior Signed-off-by: subhramit <subhramit.bb@live.in> * Add more style options Signed-off-by: subhramit <subhramit.bb@live.in> * Replace unused variables Signed-off-by: subhramit <subhramit.bb@live.in> * Rename variables Signed-off-by: subhramit <subhramit.bb@live.in> * Remove default indent Signed-off-by: subhramit <subhramit.bb@live.in> * Remove unused import Signed-off-by: subhramit <subhramit.bb@live.in> * Add comment Signed-off-by: subhramit <subhramit.bb@live.in> * Add property button disable condition Signed-off-by: subhramit <subhramit.bb@live.in> * Localization keys Signed-off-by: subhramit <subhramit.bb@live.in> * Fix tests, add changelog entries Signed-off-by: subhramit <subhramit.bb@live.in> * Add links to changelog entries Signed-off-by: subhramit <subhramit.bb@live.in> * Refine comment Signed-off-by: subhramit <subhramit.bb@live.in> * Add note Signed-off-by: subhramit <subhramit.bb@live.in> --------- Signed-off-by: subhramit <subhramit.bb@live.in> Co-authored-by: DTT12912 <derictonythomas@gmail.com>

initial commit

4177dad

trag-bot Bot reviewed May 2, 2025

View reviewed changes

Comment thread jabgui/src/main/java/org/jabref/gui/openoffice/ModifyCSLBibliographyTitleDialogView.java

trag-bot Bot reviewed May 2, 2025

View reviewed changes

Comment thread jablib/src/main/java/org/jabref/logic/openoffice/oocsltext/CSLCitationOOAdapter.java

subhramit reviewed May 2, 2025

View reviewed changes

Default styles updated

9864748

trag-bot Bot reviewed May 2, 2025

View reviewed changes

Comment thread jablib/src/main/java/org/jabref/logic/openoffice/OpenOfficePreferences.java

trag-bot Bot reviewed May 2, 2025

View reviewed changes

Comment thread jablib/src/main/java/org/jabref/logic/openoffice/OpenOfficePreferences.java

DTT12912 added 3 commits May 2, 2025 17:34

Merge branch 'main' into fix-issue-13049

f4af1eb

Fix localization strings for bibliography formatting

4243341

Merge branch 'fix-issue-13049' of https://github.com/DTT12912/jabref …

ac5ff9d

…into fix-issue-13049

subhramit mentioned this pull request May 7, 2025

CSL4LibreOffice - I [Bibliography formatting] #13074

Merged

7 tasks

subhramit closed this May 7, 2025

subhramit mentioned this pull request May 7, 2025

Use Bibliography Heading and Bibliography 1 styles for OO integration #13049

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for LibreOffice's default bibliography styles#13050

Add support for LibreOffice's default bibliography styles#13050
DTT12912 wants to merge 5 commits into
JabRef:mainfrom
DTT12912:fix-issue-13049

DTT12912 commented May 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

subhramit May 2, 2025

Uh oh!

subhramit commented May 2, 2025

Uh oh!

subhramit commented May 2, 2025 •

edited

Loading

Uh oh!

DTT12912 commented May 2, 2025 •

edited

Loading

Uh oh!

subhramit commented May 2, 2025

Uh oh!

Uh oh!

Uh oh!

trag-bot Bot commented May 2, 2025

Uh oh!

jabref-machine commented May 2, 2025

Uh oh!

subhramit commented May 7, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

DTT12912 commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mandatory checks

Uh oh!

Uh oh!

Uh oh!

subhramit May 2, 2025

Choose a reason for hiding this comment

Uh oh!

subhramit commented May 2, 2025

Uh oh!

subhramit commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DTT12912 commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

subhramit commented May 2, 2025

Uh oh!

Uh oh!

Uh oh!

trag-bot Bot commented May 2, 2025

Uh oh!

jabref-machine commented May 2, 2025

Uh oh!

subhramit commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DTT12912 commented May 2, 2025 •

edited

Loading

subhramit commented May 2, 2025 •

edited

Loading

DTT12912 commented May 2, 2025 •

edited

Loading

subhramit commented May 7, 2025 •

edited

Loading