Skip to content

drag'n'drop now works#12871

Merged
Siedlerchr merged 6 commits into
JabRef:mainfrom
GriffinCostello:dragndrop-branch
Apr 3, 2025
Merged

drag'n'drop now works#12871
Siedlerchr merged 6 commits into
JabRef:mainfrom
GriffinCostello:dragndrop-branch

Conversation

@GriffinCostello

Copy link
Copy Markdown
Contributor

Closes #12561

ViewModelListCellFactory.java contained the calls to the OnDrag() properties like onDragOver() and onDragDrop(), which were necessary for the drag and drop functionality. We added an event.consume() call and a call to the parent to restart the indicator for the drag and drop file indicator. This allowed us to repeatedly drag and drop files in the correct cell.

image
Now works

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor
koppor previously requested changes Apr 1, 2025
Comment thread CHANGELOG.md Outdated
Comment thread src/main/java/org/jabref/gui/util/ViewModelListCellFactory.java Outdated
GriffinCostello and others added 3 commits April 1, 2025 11:09
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 2, 2025

@Siedlerchr Siedlerchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@Siedlerchr Siedlerchr enabled auto-merge April 2, 2025 18:48
@Siedlerchr Siedlerchr added this pull request to the merge queue Apr 2, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 2, 2025
@Siedlerchr

Copy link
Copy Markdown
Member

seeems like a tempoary issue with the snapshot dependency

@GriffinCostello

Copy link
Copy Markdown
Contributor Author

Is there anything I can do to remedy this issue? Or should I try again in a little while?

@Siedlerchr

Copy link
Copy Markdown
Member

I saw that the snapshot is no longer available because they released it now, it's fixed in #12879 just wait until that is merged in main and re-merge

@trag-bot

trag-bot Bot commented Apr 3, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@Siedlerchr Siedlerchr added this pull request to the merge queue Apr 3, 2025
Merged via the queue into JabRef:main with commit d10f47e Apr 3, 2025
krishnagjsForGit pushed a commit to krishnagjsForGit/jabref that referenced this pull request May 2, 2025
* drag'n'drop now works

* Update CHANGELOG.md

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

* Update src/main/java/org/jabref/gui/util/ViewModelListCellFactory.java

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

---------

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
krishnagjsForGit pushed a commit to krishnagjsForGit/jabref that referenced this pull request May 2, 2025
* drag'n'drop now works

* Update CHANGELOG.md

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

* Update src/main/java/org/jabref/gui/util/ViewModelListCellFactory.java

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

---------

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Siedlerchr added a commit that referenced this pull request Dec 15, 2025
github-merge-queue Bot pushed a commit that referenced this pull request Dec 15, 2025
* Fix dnd reordering in linked files

Follow up from #12871

* changelog
Siva-Sai22 pushed a commit to Siva-Sai22/jabref that referenced this pull request Dec 19, 2025
* Fix dnd reordering in linked files

Follow up from JabRef#12871

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drag'n'drop of PDF does nothing

3 participants