drag'n'drop now works#12871
Merged
Merged
Conversation
This was referenced Apr 1, 2025
Closed
koppor
previously requested changes
Apr 1, 2025
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Member
|
seeems like a tempoary issue with the snapshot dependency |
Contributor
Author
|
Is there anything I can do to remedy this issue? Or should I try again in a little while? |
Member
|
I saw that the snapshot is no longer available because they released it now, it's fixed in #12879 just wait until that is merged in main and re-merge |
|
@trag-bot didn't find any issues in the code! ✅✨ |
Siedlerchr
approved these changes
Apr 3, 2025
krishnagjsForGit
pushed a commit
to krishnagjsForGit/jabref
that referenced
this pull request
May 2, 2025
* drag'n'drop now works * Update CHANGELOG.md Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> * Update src/main/java/org/jabref/gui/util/ViewModelListCellFactory.java Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> --------- Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
krishnagjsForGit
pushed a commit
to krishnagjsForGit/jabref
that referenced
this pull request
May 2, 2025
* drag'n'drop now works * Update CHANGELOG.md Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> * Update src/main/java/org/jabref/gui/util/ViewModelListCellFactory.java Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> --------- Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
5 tasks
3 tasks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
* Fix dnd reordering in linked files Follow up from #12871 * changelog
Siva-Sai22
pushed a commit
to Siva-Sai22/jabref
that referenced
this pull request
Dec 19, 2025
* Fix dnd reordering in linked files Follow up from JabRef#12871 * changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12561
ViewModelListCellFactory.java contained the calls to the OnDrag() properties like onDragOver() and onDragDrop(), which were necessary for the drag and drop functionality. We added an event.consume() call and a call to the parent to restart the indicator for the drag and drop file indicator. This allowed us to repeatedly drag and drop files in the correct cell.
Now works
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)