Add validations to file directories in library properties#12867
Merged
Conversation
koppor
previously requested changes
Mar 31, 2025
koppor
reviewed
Apr 2, 2025
Contributor
Author
|
@koppor I was wondering to have any direction you might have, as it would help in ongoing improvements on requested review. |
Siedlerchr
reviewed
Apr 6, 2025
Member
|
Just one change, rest is good |
Member
|
Changelog entry is missing |
|
@trag-bot didn't find any issues in the code! ✅✨ |
Siedlerchr
approved these changes
Apr 6, 2025
Member
|
Does not work with relative paths. My JabRef does not work any more. See #13017. |
5 tasks
krishnagjsForGit
pushed a commit
to krishnagjsForGit/jabref
that referenced
this pull request
May 2, 2025
* Add validations to file directories in library properties * Add error dialog for file directories in library properties * Add comment to LibraryPropertiesView * Improve directory validation condition * Refactor directory validation visualizers in library properties dialog * Add CHANGELOG.md entry
krishnagjsForGit
pushed a commit
to krishnagjsForGit/jabref
that referenced
this pull request
May 2, 2025
* Add validations to file directories in library properties * Add error dialog for file directories in library properties * Add comment to LibraryPropertiesView * Improve directory validation condition * Refactor directory validation visualizers in library properties dialog * Add CHANGELOG.md entry
Member
Contributor
Author
|
I propose implementing a warning notification system while saving other preferences and setting the directory to a default location. This approach will also retain the user's chosen directory in the event they switch back to a machine with a defined directory. I will create a follow-up PR to address these changes. |
Member
No - because the directory will work on another machine 😅 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #11840
Change under
librarypropertiesvalidateDirectorymethod to check if a directory exists and is valid.validateAndShowErrormethod to display error messages for invalid statuses.validateSettingsmethod to validate multiple directory statuses and show errors if any.Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)