Skip to content

[OO/CSL] Instantaneous citation insertion and refresh#12851

Merged
calixtus merged 2 commits into
mainfrom
csl-refresh
Mar 29, 2025
Merged

[OO/CSL] Instantaneous citation insertion and refresh#12851
calixtus merged 2 commits into
mainfrom
csl-refresh

Conversation

@subhramit

@subhramit subhramit commented Mar 29, 2025

Copy link
Copy Markdown
Member

Follow-up to #12472 (and prior)

Change

  • Use controller locking to prevent document refresh during writing.
    Drastically improves the performance of write operations in the document, making them appear almost instantaneous (earlier, there used to be a "flicker" effect, causing delay when inserting/updating citations/bibliography - which especially used to get increasingly worse as the number of citations increased).

Before:

bandicam.2025-03-30.01-26-31-474.online-video-cutter.com.mp4

After:

bandicam.2025-03-30.00-16-55-332.online-video-cutter.com.mp4

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
@subhramit subhramit changed the title Use controller locks [OO/CSL] Instantaneous citation insertion and refresh Mar 29, 2025
@trag-bot

trag-bot Bot commented Mar 29, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@github-actions

github-actions Bot commented Mar 29, 2025

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool!

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 29, 2025
@calixtus calixtus added this pull request to the merge queue Mar 29, 2025
Merged via the queue into main with commit dced032 Mar 29, 2025
@calixtus calixtus deleted the csl-refresh branch March 29, 2025 23:51
@subhramit subhramit removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 30, 2025
krishnagjsForGit pushed a commit to krishnagjsForGit/jabref that referenced this pull request May 2, 2025
* Use controller locks

Signed-off-by: subhramit <subhramit.bb@live.in>

* Add changelog entry

Signed-off-by: subhramit <subhramit.bb@live.in>

---------

Signed-off-by: subhramit <subhramit.bb@live.in>
krishnagjsForGit pushed a commit to krishnagjsForGit/jabref that referenced this pull request May 2, 2025
* Use controller locks

Signed-off-by: subhramit <subhramit.bb@live.in>

* Add changelog entry

Signed-off-by: subhramit <subhramit.bb@live.in>

---------

Signed-off-by: subhramit <subhramit.bb@live.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants