#12536 - adding '$' to the unwanted_citation_key_characters#12796
Merged
Conversation
Contributor
Author
|
PR for the docs |
subhramit
previously approved these changes
Mar 22, 2025
Member
|
User facing change requires a change log entry |
Member
|
@jnchin314 why is the mandatory check ticked if you didn't add a changelog entry? Did you read before ticking the rest? |
Contributor
Author
|
Ahh my bad. I didn't commit and push it! |
calixtus
approved these changes
Mar 22, 2025
calixtus
requested changes
Mar 22, 2025
calixtus
left a comment
Member
There was a problem hiding this comment.
You put your entry in the already published part 6.0-alpha. It belongs in the unreleased part.
calixtus
approved these changes
Mar 22, 2025
Member
|
Fixed it |
subhramit
approved these changes
Mar 22, 2025
|
👋 Hey! As a free user, you're receiving reviews for every 5th PR. Upgrade to get reviews on every pull request and boost your code quality! Learn more here 🚀 |
Contributor
Author
|
Thanks for fixing I would've moved it to the correct spot. I'll remember this for next time! |
Member
|
Prefernce migration is missing! |
GuilhermeRibeiroPereira
pushed a commit
to GuilhermeRibeiroPereira/jabref
that referenced
this pull request
Apr 1, 2025
…bRef#12796) * JabRef#12536 - adding '$' to the unwanted_citation_key_characters as a default. * JabRef#12536 - changelog! * Update CHANGELOG.md --------- Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ult.
Closes #12536
I added the $ to the default unwanted_citation_key_characters
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)