Create tests to fix #473#1269
Merged
Merged
Conversation
Contributor
Author
|
Possible solution: use prepared statements, which should solve this issue automatically. And they should be faster and safer to execute as well. |
Member
|
@simonharrer Yep, I would support that. And second you could use them for MYSQL as well |
Contributor
Author
|
Another issue: the we currently support the export of a JabRef database to an SQL file using the syntax for MySQL or PostgreSQL. But this SQL file does not contain the correct escape logic, and it is very hard to get this info out of JDBC without a database connection. Hence, I would suggest to remove these actions, as I cannot see how they are useful without the correct escape logic. |
| } | ||
|
|
||
| } | ||
| //Unfortunatley, AutoCloseable throws only Exception |
Member
|
LGTM 👍 |
Siedlerchr
added a commit
to Siedlerchr/jabref
that referenced
this pull request
Apr 22, 2016
* master: Syntaxfix Updated jabref_tr.properties Cleanup now uses active preferences (JabRef#1261) Create tests to fix JabRef#473 (JabRef#1269) Fix JabRef#1268 Canceling an import into current/new database still triggers an import Remove some unused code in ImportInspector Small errors Replace general get/put/remove metadata calls with typed versions # Conflicts: # src/main/java/net/sf/jabref/sql/SQLUtil.java # src/main/java/net/sf/jabref/sql/exporter/DatabaseExporter.java # src/test/java/net/sf/jabref/sql/DatabaseImportExportTests.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.