Improve Check Integrity Dialog: Single-click focuses field, double-click closes dialog#12679
Merged
Conversation
calixtus
reviewed
Mar 10, 2025
Comment on lines
+77
to
+81
| messagesTable.setRowFactory(tableView -> { | ||
| TableRow<IntegrityMessage> row = new TableRow<>(); | ||
| addRowMouseEvent(row); | ||
| return row; | ||
| }); |
Member
There was a problem hiding this comment.
I think you can use ViewModelTableRowFactory<S> here.
Contributor
Author
There was a problem hiding this comment.
Is this what you mean messagesTable.setRowFactory(new ViewModelTableRowFactory<IntegrityMessage>() .withOnMouseClickedEvent(this::handleRowClick));
Member
There was a problem hiding this comment.
best practice is not to mix argument style and fluent style.
use ViewModelTableRowFactory#install
Contributor
Author
There was a problem hiding this comment.
Let me know if I still need to change it.
koppor
previously approved these changes
Mar 11, 2025
|
@trag-bot didn't find any issues in the code! ✅✨ |
calixtus
approved these changes
Mar 11, 2025
Member
|
Codewise looks good to me. |
GuilhermeRibeiroPereira
pushed a commit
to GuilhermeRibeiroPereira/jabref
that referenced
this pull request
Apr 1, 2025
…ick closes dialog (JabRef#12679) * Improve Check Integrity dialog entry interaction * Use ViewModelTableRowFactory --------- Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12245.
This PR updates the Check Integrity dialog behavior: a single click now focuses the field, and a double-click both focuses and closes the dialog.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)After Single Click
After Double Click