Added support for (biblatex) langid to be an optional field in entry editor#12071
Conversation
… into gui and program logic
koppor
left a comment
There was a problem hiding this comment.
Initial comments.
Please re-iterate on the biblatex smanual and check whether language and origLanguage also have the same values. If yes, your editor can be used if the field proprty FieldProperty.LANGUAGE langauge is present. If not, then this property can just be remoed.
In other words FieldPropety groups fields together and indicates the editor for it. Do not introduce a property if it used for one field only.
- removed redundant description in CHANGELOG.md - removed unnecessary gradle properties - removed unnecessary tests - fixed formatting/commented out code
koppor
left a comment
There was a problem hiding this comment.
Tests are a bit too verbose and not confirming to the one-assertion-per-test rule. Please streamline.
Other comments inside.
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
There was a problem hiding this comment.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
You can check review dog's comments at the tab "Files changed" of your pull request.
…ing: - refactored and renamed LangidEditorViewModel.java to LanguageEditorViewModel (and tests) - re-added gradle property - reverted edits to BibtexEntryTypeDefinitions.java - removed FieldProperty.LANGUAGEID so both language and langid standard fields have FieldProperty.LANGUAGE NB: Still yet to fix tests
…into 10868-support-for-langid-field # Conflicts: # gradle.properties
There was a problem hiding this comment.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
You can check review dog's comments at the tab "Files changed" of your pull request.
koppor
left a comment
There was a problem hiding this comment.
Minor comments.
Tests have to be rewritten to fit JabRef style.
No text for failing assertions.
There was a problem hiding this comment.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
There was a problem hiding this comment.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
There was a problem hiding this comment.
Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun, check the results, commit, and push.
You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".
* upstream/main: New Crowdin updates (#12264) New Crowdin updates (#12263) 11219 adapt UI font size (#12042) Added support for (biblatex) `langid` to be an optional field in entry editor (#12071) improve unlinked files dialog (#12195) Reword 0034-use-citation-key-for-grouping-chat-messages.md (#12183) Bump dev.langchain4j:langchain4j-open-ai from 0.36.0 to 0.36.2 (#12259) Bump io.zonky.test.postgres:embedded-postgres-binaries-bom (#12258) Bump tech.units:indriya from 2.2 to 2.2.1 (#12257) Bump org.jetbrains.kotlin:kotlin-stdlib-jdk8 from 2.0.21 to 2.1.0 (#12256) Bump io.github.classgraph:classgraph from 4.8.177 to 4.8.179 (#12255) Bump src/main/resources/csl-styles from `b90b81a` to `6b7b611` (#12254) Add hints on research (and BibTeX) to README.md (#12253) Disable non-working Openrewrite recipe always set maximized to false on exit for mac (#12248)
Overview:
Integrated 'langid' into all biblatex/bibtex supported entry types as an optional field. This is so formatting of entries can be adapted to the language of the entries. Closes #10868.
Changes implemented:
langid.video.mp4
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)