Skip to content

Fix fetcher tests#11737

Merged
subhramit merged 6 commits into
mainfrom
fetcher-tests
Sep 9, 2024
Merged

Fix fetcher tests#11737
subhramit merged 6 commits into
mainfrom
fetcher-tests

Conversation

@subhramit

@subhramit subhramit commented Sep 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes:

  • OpenAccessDoiTest
  • TitleFetcherTest

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr previously approved these changes Sep 9, 2024
View reviewed changes
@subhramit subhramit marked this pull request as ready for review September 9, 2024 10:17
@subhramit subhramit mentioned this pull request Sep 9, 2024
Merged
3 tasks
@subhramit subhramit changed the title Fix fetcher test Fix fetcher tests Sep 9, 2024
Siedlerchr
Siedlerchr reviewed Sep 9, 2024
View reviewed changes
Comment thread src/test/java/org/jabref/logic/importer/fetcher/OpenAccessDoiTest.java Outdated
@subhramit subhramit requested a review from Siedlerchr September 9, 2024 10:48
Siedlerchr
Siedlerchr previously approved these changes Sep 9, 2024
View reviewed changes
@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 9, 2024
@subhramit subhramit removed this pull request from the merge queue due to a manual request Sep 9, 2024
@subhramit subhramit added this pull request to the merge queue Sep 9, 2024
@Siedlerchr Siedlerchr removed this pull request from the merge queue due to a manual request Sep 9, 2024
Siedlerchr
Siedlerchr reviewed Sep 9, 2024
View reviewed changes
Comment thread src/test/java/org/jabref/logic/importer/fetcher/OpenAccessDoiTest.java Outdated
@subhramit subhramit enabled auto-merge September 9, 2024 11:49
@subhramit subhramit added this pull request to the merge queue Sep 9, 2024
@github-actions

github-actions Bot commented Sep 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit 1f7d900 Sep 9, 2024
@subhramit subhramit deleted the fetcher-tests branch September 9, 2024 12:17
leaf-soba pushed a commit to leaf-soba/jabref that referenced this pull request Sep 11, 2024
@subhramit
Fix fetcher tests (JabRef#11737)
0e99507 
* Add volume information

* Add pages

* Fix OpenAccessDOITest

* Revert openaccesssdoifetcher result

* Change test openAccess article

* remove .pdf extension from expected arg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

component: fetcher dev: testing Related to tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@subhramit @Siedlerchr