Skip to content

Add pref switch to not store url#11735

Merged
Siedlerchr merged 10 commits into
mainfrom
addPrefSwitchToNotStoreUrl
Sep 9, 2024
Merged

Add pref switch to not store url#11735
Siedlerchr merged 10 commits into
mainfrom
addPrefSwitchToNotStoreUrl

Conversation

@Siedlerchr

Copy link
Copy Markdown
Member

Refs https://discourse.jabref.org/t/import-adds-pdf-link-and-url-to-file-entry/4484/2

Follow up from #10848

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

github-actions[bot]

This comment was marked as outdated.

@koppor koppor force-pushed the addPrefSwitchToNotStoreUrl branch from 1375fee to 4a52c01 Compare September 9, 2024 08:56
github-actions[bot]

This comment was marked as outdated.

koppor and others added 6 commits September 9, 2024 10:59
… into addPrefSwitchToNotStoreUrl

* 'addPrefSwitchToNotStoreUrl' of github.com:JabRef/jabref:
  Update CHANGELOG.md
@Siedlerchr Siedlerchr enabled auto-merge September 9, 2024 09:49
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 9, 2024
koppor
koppor previously approved these changes Sep 9, 2024
@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 9, 2024
@github-actions

github-actions Bot commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit 85d8d8a Sep 9, 2024
@Siedlerchr Siedlerchr deleted the addPrefSwitchToNotStoreUrl branch September 9, 2024 10:41
leaf-soba pushed a commit to leaf-soba/jabref that referenced this pull request Sep 11, 2024
* Add option to disable keeping download url

Refs https://discourse.jabref.org/t/import-adds-pdf-link-and-url-to-file-entry/4484/

* Fix checkstyle

* Compilefix

* add default

* Update CHANGELOG.md

* add addtional check

* fix ui

* fix test

* fix fcking test

---------

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: preferences status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants