Skip to content

Fix ArgumentProcessor#11728

Merged
koppor merged 6 commits into
mainfrom
fix-cross-deps
Sep 8, 2024
Merged

Fix ArgumentProcessor#11728
koppor merged 6 commits into
mainfrom
fix-cross-deps

Conversation

@koppor

@koppor koppor commented Sep 8, 2024

Copy link
Copy Markdown
Member

Fixes an architectural flaw

Refs #110

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor and others added 5 commits September 8, 2024 11:45
@koppor
Refine JavaDoc
201a708
@koppor @calixtus
Add TODOs
86eea9b 
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
@koppor
Fix typos
fa6c90e
@koppor
Reoder settings
b1cd984
@koppor @Siedlerchr @calixtus
Fix arch flaw
1d38f85 
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
@koppor koppor enabled auto-merge September 8, 2024 11:38
Siedlerchr
Siedlerchr previously approved these changes Sep 8, 2024
View reviewed changes
@koppor koppor added this pull request to the merge queue Sep 8, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 8, 2024
@koppor koppor enabled auto-merge September 8, 2024 16:17
@koppor koppor added this pull request to the merge queue Sep 8, 2024
@github-actions

github-actions Bot commented Sep 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit f49dfac Sep 8, 2024
@koppor koppor deleted the fix-cross-deps branch September 8, 2024 16:35
@koppor koppor mentioned this pull request Sep 8, 2024
Merged
6 tasks
leaf-soba pushed a commit to leaf-soba/jabref that referenced this pull request Sep 11, 2024
@koppor @calixtus @Siedlerchr
Fix ArgumentProcessor (JabRef#11728)
8b168ee 
* Refine JavaDoc

* Add TODOs

Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>

* Fix typos

* Reoder settings

* Fix arch flaw

Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>

* Fix checkstyle and formatting

---------

Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

project: jabcon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koppor @Siedlerchr