Remove unnecessary AI dependencies#11727
Merged
Merged
Conversation
calixtus
approved these changes
Sep 8, 2024
6 tasks
leaf-soba
pushed a commit
to leaf-soba/jabref
that referenced
this pull request
Sep 11, 2024
* Remove unnecessary AI dependencies * Remove AiApiKeyProvider.java * Fix checkers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unnecessary
AiService(it turns out there is no that much code, I used InelliJ analysis tools). Also removedAiApiKeyProvider, the code for API keys is now in theAiPreferences.Mandatory checks
- [ ] Change inCHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)- [ ] Tests created for changes (if applicable)- [ ] Screenshots added in PR description (for UI changes)