Enable triggering offline parsing explicitely#11565
Merged
Merged
Conversation
- Refactor actions to inheritance instead of if-statements in a class - Solved "fun" with inheritance and FXML - Use %0 and offline/offline parameterization - Rename "GROBID" to "Grobid"
Siedlerchr
reviewed
Aug 1, 2024
| } | ||
|
|
||
| repositories { | ||
| mavenLocal() |
Member
Author
There was a problem hiding this comment.
I needed mavenLocal() to be able to load the patched version org.jabref:afterburner.fx:2.0.0-SNAPSHOT.
Not required any more.
Siedlerchr
reviewed
Aug 1, 2024
Siedlerchr
reviewed
Aug 1, 2024
Siedlerchr
reviewed
Aug 1, 2024
Member
Author
|
Just for reference: Code with inheritance side-by-side:
I will now try to use composition. Let's see, how it will work out. |
Member
Author
|
Rewritten, now we have an public void startParsing() {
if (onlineMode) {
startParsingOnline();
} else {
startParsingOffline();
}
}This is OK for me. |
koppor
commented
Aug 2, 2024
|
|
||
| Platform.runLater(() -> { | ||
| input.requestFocus(); | ||
| Button buttonParse = (Button) getDialogPane().lookupButton(parseButtonType); |
Member
Author
There was a problem hiding this comment.
I need to have this code here, because otherwise, I get
Caused by: java.lang.NullPointerException: Cannot invoke "javafx.scene.control.Button.setTooltip(javafx.scene.control.Tooltip)" because "buttonParse" is null
# Conflicts: # src/main/java/org/jabref/gui/actions/StandardActions.java # src/main/resources/l10n/JabRef_en.properties
Siedlerchr
reviewed
Aug 2, 2024
| public ExtractBibtexDialog(boolean onlineMode) { | ||
| this.onlineMode = onlineMode; | ||
| ViewLoader.view(this) | ||
| .controller(this) |
Member
Author
There was a problem hiding this comment.
Oh, I thought, I could not it get to work without this... Strange. Removed.
Siedlerchr
previously approved these changes
Aug 4, 2024
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New online/offline distinction more visible in the UI:
Library menu:
Button on toolbar still asks for permission:
If "Do not ask again" (and Yes)
Additionally:
Feature: clipboard contents now contained automatically:
(You also see here "online" and "offline" indication at the dialog title)
Feature itself is described at https://docs.jabref.org/collect/newentryfromplaintext.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)