Add support for inheritance of dialogs#17
Closed
koppor wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Sorry, even with more cleaner code, it doesn't work without that patch. |
6 tasks
calixtus
approved these changes
Aug 1, 2024
Member
Author
|
@calixtus Required by JabRef/jabref#11565. I hope, I find time to propose another solution using some composition or helper class instead of one-level inheritance. |
Member
Author
|
Not required. We went for if then else |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You all know, I like inheritance instead of swich/case or ifs. Therefore, I crafted following code for the super class:
classDiagram ExtractBibtexDialog <|-- ExtractBibtexDialogGrobid ExtractBibtexDialog <|-- ExtractBibtexDialogOffline--
I could solve it differently. Leaving this PR for future reference