Save unlinked local files dialog prefs#11493
Merged
Siedlerchr merged 4 commits intoJul 16, 2024
Merged
Conversation
koppor
requested changes
Jul 15, 2024
koppor
left a comment
Member
There was a problem hiding this comment.
In general, looks good.
Please just remove the option to enable storing --> It should always be stored. (I know, the issue asked otherwise, that slipped through while making it a good first issue)
koppor
approved these changes
Jul 16, 2024
koppor
left a comment
Member
There was a problem hiding this comment.
Looks good to me! PR awaits a second review, since I am not fully into the preferences handling.
Siedlerchr
approved these changes
Jul 16, 2024
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for your contribution! lgtm
Siedlerchr
added a commit
to subhramit/jabref
that referenced
this pull request
Jul 19, 2024
* upstream/main: Fix NPE when saving preferences (JabRef#11509) Switch to stream-based loading (JabRef#11479) Save unlinked local files dialog prefs (JabRef#11493) Add minimal support for biblatex data annotations (JabRef#11506) Fix handling of relative-file storage and auto linking (JabRef#11492) New Crowdin updates (JabRef#11504) Add missing issue numbers CSL4LibreOffice - A [GSoC '24] (JabRef#11477) Bump src/main/resources/csl-styles from `b2be5ae` to `fd6cb3e` (JabRef#11501) Bump gittools/actions from 1.1.1 to 1.2.0 (JabRef#11500) Bump com.kohlschutter.junixsocket:junixsocket-core from 2.9.1 to 2.10.0 (JabRef#11498) Bump commons-logging:commons-logging from 1.3.2 to 1.3.3 (JabRef#11499) Bump org.jsoup:jsoup from 1.17.2 to 1.18.1 (JabRef#11497) Bump com.kohlschutter.junixsocket:junixsocket-mysql from 2.9.1 to 2.10.0 (JabRef#11496) Bump org.openrewrite.recipe:rewrite-recipe-bom from 2.14.0 to 2.15.0 (JabRef#11495) FAQ updates (JabRef#11486) Update Gradle Wrapper from 8.8 to 8.9. Fix Chocolate.bib (JabRef#11491) # Conflicts: # src/main/java/org/jabref/gui/openoffice/OOBibBase.java # src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java # src/main/java/org/jabref/gui/openoffice/StyleSelectDialogView.java # src/main/java/org/jabref/gui/openoffice/StyleSelectDialogViewModel.java # src/main/java/org/jabref/preferences/JabRefPreferences.java
2 tasks
Member
|
@kataramarina For your info, there was a little bug which resulted in an exception which prevented the opening of the dialog See #11553 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new check in the dialog that allows to save selected options of the dialog through the work and in the propgram preferences.
Closes #11439
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)