Skip to content

improve error handling for bibdesk files#11118

Merged
Siedlerchr merged 3 commits into
mainfrom
improveErrorHandlingForBibDesk
Apr 1, 2024
Merged

improve error handling for bibdesk files#11118
Siedlerchr merged 3 commits into
mainfrom
improveErrorHandlingForBibDesk

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Mar 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #11117

Improve error handling for bibdesk linked files parsing

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr mentioned this pull request Mar 31, 2024
Closed
2 tasks
@Siedlerchr
add changelog entry, refine error message
a3368c5 
Signed-off-by: Siedlerchr <siedlerkiller@gmail.com>
@Siedlerchr Siedlerchr requested a review from koppor March 31, 2024 16:07
@Siedlerchr Siedlerchr enabled auto-merge March 31, 2024 16:08
koppor
koppor requested changes Mar 31, 2024
View reviewed changes

@koppor koppor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment.

Can we add a test? 😅 (With anonymized data)

Comment thread src/main/java/org/jabref/logic/importer/fileformat/BibtexParser.java Outdated
@Siedlerchr Siedlerchr requested a review from koppor April 1, 2024 13:59
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 1, 2024
@github-actions

github-actions Bot commented Apr 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Apr 1, 2024
Merged via the queue into main with commit 036f4bf Apr 1, 2024
@Siedlerchr Siedlerchr deleted the improveErrorHandlingForBibDesk branch April 1, 2024 14:30
Siedlerchr added a commit that referenced this pull request Apr 1, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into contentSelectorDefa…
c2c1427 
…utlSaving

* upstream/main:
  Bump com.puppycrawl.tools:checkstyle from 10.14.2 to 10.15.0 (#11121)
  Bump com.dlsc.gemsfx:gemsfx from 2.4.0 to 2.6.0 (#11120)
  improve error handling for bibdesk files (#11118)
  Update CSL styles (#11119)
  New translations jabref_en.properties (German) (#11116)
  New Crowdin updates (#11115)
  Remove obsolete sentence (#11114)
  add json file
  Remove warnings shown when importing search entries in unsaved libraries (#11111)
  New Crowdin updates (#11112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koppor koppor koppor approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

error Input byte array has wrong 4-byte ending unit

2 participants

@Siedlerchr @koppor