Fix escaping of slashes for TexShop#10826
Merged
Merged
Conversation
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
koppor
reviewed
Jan 28, 2024
Member
Author
|
I would not make it too complicated. I doubt that we have nested quotes
here.
The key issue was that the backslash was not escaped correctly.
Test cases don't make sense as it's mac only
Oliver Kopp ***@***.***> schrieb am So., 28. Jan. 2024, 09:26:
… ***@***.**** commented on this pull request.
------------------------------
In src/main/java/org/jabref/gui/push/PushToTexShop.java
<#10826 (comment)>:
> }
String osascriptTexShop = "osascript -e 'tell application \"TeXShop\"\n" +
"activate\n" +
- "set TheString to " + citeCommand + keyString + getCiteSuffix() + "\"\n" +
+ "set TheString to \"" + citeCommand + keyString + getCiteSuffix() + "\"\n" +
It seems that nested "" won't work. Think, we don't need to handle that
cases?
Do we need some test cases here? 😅
—
Reply to this email directly, view it on GitHub
<#10826 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACOFZFJ46LTYKD2N7IVWBTYQYDUNAVCNFSM6AAAAABCNSSA6KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBXGQ2DANRXHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Siedlerchr
added a commit
that referenced
this pull request
Feb 3, 2024
* upstream/main: Fix NPE when tab is close during load (#10841) Bump peter-evans/create-or-update-comment from 3 to 4 (#10838) Bump styfle/cancel-workflow-action from 0.12.0 to 0.12.1 (#10835) Bump lycheeverse/lychee-action from 1.9.1 to 1.9.3 (#10837) Bump gradle/gradle-build-action from 2 to 3 (#10836) Bump com.puppycrawl.tools:checkstyle from 10.12.7 to 10.13.0 (#10830) Bump org.mockito:mockito-core from 5.9.0 to 5.10.0 (#10834) Bump org.openrewrite.rewrite from 6.7.0 to 6.8.1 (#10833) Bump org.openrewrite.recipe:rewrite-recipe-bom from 2.6.2 to 2.6.3 (#10832) Apply RemoveTestPrefix (#10823) Update to jdk 21.0.2 (#10827) Fix escaping of slashes for TexShop (#10826)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://discourse.jabref.org/t/push-to-texshop-mac/2699/17?u=siedlerchr
This alllows
~\cite{key1,key2}Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)