Skip to content

Apply RemoveTestPrefix (and fix some issues manually)#10799

Closed
koppor wants to merge 3 commits into
mainfrom
add-junit5-best-practices
Closed

Apply RemoveTestPrefix (and fix some issues manually)#10799
koppor wants to merge 3 commits into
mainfrom
add-junit5-best-practices

Conversation

@koppor

@koppor koppor commented Jan 15, 2024

Copy link
Copy Markdown
Member

Follow-up to #10797

99% of the rewrite worked. I just had to manually exclude some files and make some adaptions (copy three test files, make JavaDoc links full links)

Opened upstream issues:

Existing upstream issue: openrewrite/rewrite-testing-frameworks#258

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor marked this pull request as draft January 16, 2024 16:44
@Siedlerchr

Copy link
Copy Markdown
Member

Task :test
org.jabref.gui.mergeentries.ThreeWayMergeCellViewModelTest

oddEvenLogic(boolean, boolean, boolean, boolean)

Test initializationError FAILED

org.junit.platform.commons.PreconditionViolationException: Could not find factory method [oddEvenLogic] in class [org.jabref.gui.mergeentries.ThreeWayMergeCellViewModelTest]

org.jabref.logic.citationkeypattern.CitationKeyGeneratorTest

authorsAlpha(String, BibEntry, String)

Test initializationError FAILED

org.junit.platform.commons.PreconditionViolationException: Could not find factory method [authorsAlpha] in class [org.jabref.logic.citationkeypattern.CitationKeyGeneratorTest]

org.jabref.logic.citationstyle.CitationStyleGeneratorTest

cslMapping(String, BibDatabaseMode, BibEntry, String)

Test initializationError FAILED

org.junit.platform.commons.PreconditionViolationException: Could not find factory method [cslMapping] in class [org.jabref.logic.citationstyle.CitationStyleGeneratorTest]

org.jabref.logic.importer.fileformat.BibtexImporterTest

parsingOfEncodedFileWithHeader(Charset, String)

Test initializationError FAILED

org.junit.platform.commons.PreconditionViolationException: Could not find factory method [parsingOfEncodedFileWithHeader] in class [org.jabref.logic.importer.fileformat.BibtexImporterTest]

@github-actions

github-actions Bot commented Jan 18, 2024

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr

Copy link
Copy Markdown
Member

As this does not work I would not merge it and close it for the moment to reduce noise

@Siedlerchr Siedlerchr closed this Jan 23, 2024
@koppor

koppor commented Jan 24, 2024

Copy link
Copy Markdown
Member Author

Note that I marked it as "draft" :)

@koppor koppor changed the title Apply JUnit5BestPractices (and fix some issues manually) Apply RemoveTestPrefix (and fix some issues manually) Jan 24, 2024
@koppor

koppor commented Jan 24, 2024

Copy link
Copy Markdown
Member Author

I will focus on "RemoveTestPrefix", because this is already a huge change. I fixed the issues mentioned at #10799 (comment).

@koppor

koppor commented Jan 24, 2024

Copy link
Copy Markdown
Member Author

GitHub does not like my pushes. Thus keeping the PR closed and re-opening a clean PR.

@koppor koppor mentioned this pull request Jan 24, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants