Apply RemoveTestPrefix (and fix some issues manually)#10799
Conversation
oddEvenLogic(boolean, boolean, boolean, boolean) org.jabref.logic.citationkeypattern.CitationKeyGeneratorTest authorsAlpha(String, BibEntry, String) org.jabref.logic.citationstyle.CitationStyleGeneratorTest cslMapping(String, BibDatabaseMode, BibEntry, String) org.jabref.logic.importer.fileformat.BibtexImporterTest parsingOfEncodedFileWithHeader(Charset, String) |
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
|
As this does not work I would not merge it and close it for the moment to reduce noise |
|
Note that I marked it as "draft" :) |
|
I will focus on "RemoveTestPrefix", because this is already a huge change. I fixed the issues mentioned at #10799 (comment). |
|
GitHub does not like my pushes. Thus keeping the PR closed and re-opening a clean PR. |
Follow-up to #10797
99% of the rewrite worked. I just had to manually exclude some files and make some adaptions (copy three test files, make JavaDoc links full links)
Opened upstream issues:
TestsShouldNotBePublicshould reduce visibility if used elsewhere in Javadoc links openrewrite/rewrite-testing-frameworks#458assertEqualsopenrewrite/rewrite-testing-frameworks#459Existing upstream issue: openrewrite/rewrite-testing-frameworks#258
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)