Skip to content

Add JUnit5BestPractices#10797

Closed
koppor wants to merge 1 commit into
mainfrom
add-junit-best-practices
Closed

Add JUnit5BestPractices#10797
koppor wants to merge 1 commit into
mainfrom
add-junit-best-practices

Conversation

@koppor

@koppor koppor commented Jan 15, 2024

Copy link
Copy Markdown
Member

This rewrites all JUnit5 test cases to best practices:

  • RemoveTestPrefix
  • TestsShouldNotBePublic

Also add already applied recipes to rewrite.yml

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Also add already applied recipes
@github-actions

github-actions Bot commented Jan 15, 2024

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor

koppor commented Jan 15, 2024

Copy link
Copy Markdown
Member Author

OMG...

@Siedlerchr

Copy link
Copy Markdown
Member

ALLES KAPUTTTT!!!!!°

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants