Refactored LibraryTab#10732
Merged
Merged
Conversation
# Conflicts: # src/main/java/org/jabref/gui/JabRefFrame.java # src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java # src/main/java/org/jabref/gui/exporter/ExportCommand.java # src/main/java/org/jabref/gui/exporter/SaveAllAction.java # src/main/java/org/jabref/gui/importer/ImportCommand.java # src/main/java/org/jabref/gui/importer/actions/GUIPostOpenAction.java # src/main/java/org/jabref/gui/importer/actions/MergeReviewIntoCommentAction.java # src/main/java/org/jabref/gui/importer/actions/OpenDatabaseAction.java # src/main/java/org/jabref/gui/library/LibraryTab.java # src/main/java/org/jabref/gui/maintable/MainTable.java # src/main/java/org/jabref/gui/preferences/ShowPreferencesAction.java # src/main/java/org/jabref/gui/shared/SharedDatabaseLoginDialogViewModel.java # src/main/java/org/jabref/gui/shared/SharedDatabaseUIManager.java # src/main/java/org/jabref/gui/undo/UndoRedoAction.java # src/test/java/org/jabref/gui/exporter/SaveDatabaseActionTest.java # src/test/java/org/jabref/gui/importer/NewEntryActionTest.java
Member
|
Needs to be tested on mac as well, I remember there were some weird issues |
# Conflicts: # src/main/java/org/jabref/gui/JabRefFrame.java
Siedlerchr
reviewed
Jan 10, 2024
Member
|
should also be tested with remote SQL database |
koppor
reviewed
Jan 10, 2024
Member
There was a problem hiding this comment.
Please do not commit changes in the submodule
Member
Author
There was a problem hiding this comment.
oops, was an accident, now i have to figure out how to remove these changes
| @@ -86,6 +92,11 @@ | |||
|
|
|||
| public class LibraryTab extends Tab { | |||
Member
There was a problem hiding this comment.
Can you add design-ideas as JavaDoc?
Member
Author
There was a problem hiding this comment.
Nope, at least not yet. Would be speculation. Right now its only to get some order into the chaos.
In fact, there are still other things I wanted to do here, but i stopped to keep this reviewable. But one future step would be to get the entry editor out of the library tab and into the frame, and to fix all the bindings stuff.
Member
Author
There was a problem hiding this comment.
Another thing would be to break this class into a more classes and fixing the mvvm pattern with library tab.
Member
Author
Tested. Works. |
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
koppor
approved these changes
Jan 11, 2024
Siedlerchr
approved these changes
Jan 11, 2024
Siedlerchr
added a commit
that referenced
this pull request
Jan 12, 2024
* upstream/main: (25 commits) Remove remainging "testLogging" (#10769) Reuse JUnit 5.7's @DisabledIfEnvironmentVariable (#10768) Refactored LibraryTab (#10732) Fix annotation (#10766) Add initial .git-blame-ignore-revs (#10765) Streamline test output (#10762) Fix NPE when opening and re-opening a library (#10763) Changed default status of 'Automatically open folder of attached files' (#10748) Implement test cases for search (#10193) Add cites field to bib entries for citation relation (#10752) Ignore submodule changes (for normal devs) (#10754) Fix line endings Bump lycheeverse/lychee-action from 1.8.0 to 1.9.0 (#10760) Bump appleboy/ssh-action from 1.0.2 to 1.0.3 (#10761) Bump org.apache.lucene:lucene-core from 9.9.0 to 9.9.1 (#10759) Bump org.openrewrite.rewrite from 6.5.4 to 6.6.3 (#10758) Bump org.glassfish.jersey.containers:jersey-container-grizzly2-http (#10755) Bump org.jsoup:jsoup from 1.16.2 to 1.17.2 (#10756) Bump org.mockito:mockito-core from 5.7.0 to 5.8.0 (#10757) Remove abstract ...
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)