Extract calls to JabRefFrame and substitute with LibraryTabContainer#10724
Conversation
…SharedDatabaseCommand
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
tobiasdiez
left a comment
There was a problem hiding this comment.
Not enough time right now for a full review, but based on a cursory glance it looks good to me.
Happy new year!
| } | ||
|
|
||
| frame.getCurrentLibraryTab().markBaseChanged(); | ||
| tabSupplier.get().markBaseChanged(); |
There was a problem hiding this comment.
It looks like most of the remaining usages of the LibraryTab are now related to the "changed" status. Is it easy to push this down to the database context (as a follow-up of course)?
There was a problem hiding this comment.
We'll see. My plan is to somehow really fix the undo redo stuff and for that I want to utilize the commands we're using and maybe putting them eventually on a reactive stream. But there is still some road to walk.
Upmost next is some refactoring of libraryTab and jabrefframe
* 'main' of github.com:JabRef/jabref: Ignore 429 at link check (#10743) Fix color for hovered special fields (#10742) Adds three tests to verify the expected output from the getErroMessage function. The tests check the output message when ParserResult is empty, not empty, or has duplicates. (#10711) Extract calls to JabRefFrame and substitute with LibraryTabContainer (#10724)
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)