Synchronize scrollbars in the change resolver dialog#10587
Merged
Conversation
Member
|
Thanks for looking into this issue. Maybe this thread helps you? https://stackoverflow.com/questions/49509395/synchronize-scrollbars-of-two-javafx-webviews |
…l bar is dragged.
…ise_scrollbars
Contributor
Author
|
Thanks for the help! I've made changes to the code and it seems to work fine now (although the BibTeX window still isn't synced). |
Member
|
Tested it, works fine! Cool! Do you want to experiment with the BibTeX source tab as well? (It's okay if it's too complicated and you don't want to do this). The BibTeX source tab uses the Code Area from https://github.com/FXMisc/RichTextFX |
Contributor
Author
|
I'll probably leave the BibTeX stuff, since it does seem pretty complicated and I don't think I'll have time to implement it. |
Member
|
Okay, this is fine for me! |
Siedlerchr
approved these changes
Oct 28, 2023
koppor
approved these changes
Oct 28, 2023
Siedlerchr
added a commit
to guipmenezes/jabref
that referenced
this pull request
Nov 1, 2023
* upstream/main: (419 commits) Fix CHANGELOG.md Bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (JabRef#10607) Fix issue JabRef#9306: Move "Open only one instance of JabRef" preference option to somewhere else (JabRef#10602) Update README.md (JabRef#10604) Bump me.champeau.jmh from 0.7.1 to 0.7.2 Bump org.beryx.jlink from 3.0.0 to 3.0.1 Bump com.dlsc.gemsfx:gemsfx from 1.82.0 to 1.84.0 Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.0 to 2.21.1 Synchronize scrollbars in the change resolver dialog (JabRef#10587) Add button for a user to reset the cite command to the default value. (JabRef#10580) openrerwrite Update .github/PULL_REQUEST_TEMPLATE.md Update PULL_REQUEST_TEMPLATE.md Update .github/PULL_REQUEST_TEMPLATE.md Update PULL_REQUEST_TEMPLATE.md Replace "fixes" by "resolves" Change JavaDoc to annotation (JabRef#10571) Fix link (JabRef#10575) Enable collecting GitHub build artifacts for forks (JabRef#10574) Fix file field merging (JabRef#10573) ... # Conflicts: # src/main/java/org/jabref/gui/fieldeditors/identifier/IdentifierEditor.java # src/main/java/org/jabref/logic/importer/WebFetchers.java
Siedlerchr
added a commit
that referenced
this pull request
Nov 4, 2023
* upstream/main: (1565 commits) Enable journal information fetcher directly in popup (#10598) Make generate button wider (#10588) make openRewrite stable again Rename cleanup_pr.yml to cleanup-pr.yml Changelog Fix failing fetcher tests (#10613) ShortDoi Fix CHANGELOG.md Bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (#10607) Fix issue #9306: Move "Open only one instance of JabRef" preference option to somewhere else (#10602) Update README.md (#10604) Bump me.champeau.jmh from 0.7.1 to 0.7.2 Bump org.beryx.jlink from 3.0.0 to 3.0.1 Bump com.dlsc.gemsfx:gemsfx from 1.82.0 to 1.84.0 Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.0 to 2.21.1 Synchronize scrollbars in the change resolver dialog (#10587) Add button for a user to reset the cite command to the default value. (#10580) openrerwrite Update .github/PULL_REQUEST_TEMPLATE.md Update PULL_REQUEST_TEMPLATE.md ... # Conflicts: # .devcontainer/devcontainer.json # build.gradle # src/main/java/org/jabref/gui/DefaultInjector.java # src/main/java/org/jabref/gui/libraryproperties/general/GeneralProperties.fxml # src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesView.java # src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesViewModel.java # src/main/java/org/jabref/logic/exporter/MetaDataSerializer.java # src/main/java/org/jabref/logic/importer/util/MetaDataParser.java # src/main/java/org/jabref/model/metadata/MetaData.java # src/main/java/org/jabref/preferences/JabRefPreferences.java
Siedlerchr
added a commit
to liyou969/jabref
that referenced
this pull request
Nov 4, 2023
* upstream/main: (44 commits) change codecov (JabRef#10616) Add entry based on ISSN number JabRef#10124 (JabRef#10178) Enable journal information fetcher directly in popup (JabRef#10598) Make generate button wider (JabRef#10588) make openRewrite stable again Rename cleanup_pr.yml to cleanup-pr.yml Changelog Fix failing fetcher tests (JabRef#10613) ShortDoi Fix CHANGELOG.md Bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (JabRef#10607) Fix issue JabRef#9306: Move "Open only one instance of JabRef" preference option to somewhere else (JabRef#10602) Update README.md (JabRef#10604) Bump me.champeau.jmh from 0.7.1 to 0.7.2 Bump org.beryx.jlink from 3.0.0 to 3.0.1 Bump com.dlsc.gemsfx:gemsfx from 1.82.0 to 1.84.0 Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.0 to 2.21.1 Synchronize scrollbars in the change resolver dialog (JabRef#10587) Add button for a user to reset the cite command to the default value. (JabRef#10580) openrerwrite ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix #9576.
Set up a listener that synchronizes the scroll values of both views when one is scrolled by setting the scroll values when input is detected on the WebView. Currently only affects the entry preview, and not the BibTeX page.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)