Skip to content

Add library selection to "Aux file import"#10525

Merged
Siedlerchr merged 15 commits into
JabRef:mainfrom
caitlinlilley:main
Oct 23, 2023
Merged

Add library selection to "Aux file import"#10525
Siedlerchr merged 15 commits into
JabRef:mainfrom
caitlinlilley:main

Conversation

@caitlinlilley

@caitlinlilley caitlinlilley commented Oct 19, 2023 •
edited by ThiloteE
Loading

Copy link
Copy Markdown
Contributor

Fixes #10472

Screen Shot 2023-10-19 at 10 22 46 pm

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr reviewed Oct 19, 2023
View reviewed changes
Comment thread src/main/resources/build.properties Outdated
@Siedlerchr

Siedlerchr commented Oct 19, 2023

Copy link
Copy Markdown
Member

Now you need to pass the selected library to the parser here
https://github.com/JabRef/jabref/pull/10525/files#diff-e9244ac3e843b0df31e772c59b54ad31e14ad66f71a8be91331c43a5854becb8R76

@calixtus calixtus marked this pull request as draft October 21, 2023 20:56
koppor
koppor requested changes Oct 21, 2023
View reviewed changes

@koppor koppor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor code comments

Comment thread src/main/java/org/jabref/gui/auximport/FromAuxDialog.java Outdated
Comment thread src/main/java/org/jabref/gui/auximport/FromAuxDialog.java
@calixtus calixtus marked this pull request as ready for review October 22, 2023 22:24
@calixtus calixtus enabled auto-merge October 22, 2023 22:25
koppor
koppor previously approved these changes Oct 22, 2023
View reviewed changes
@Siedlerchr

Siedlerchr commented Oct 23, 2023

Copy link
Copy Markdown
Member

l10n seems to be missing

@Siedlerchr Siedlerchr disabled auto-merge October 23, 2023 10:22
@Siedlerchr Siedlerchr merged commit febc379 into JabRef:main Oct 23, 2023
@Siedlerchr

Siedlerchr commented Oct 23, 2023

Copy link
Copy Markdown
Member

There were only some http error codes for checking the help pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr left review comments

@koppor koppor koppor approved these changes

Assignees

No one assigned

Labels

component: ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add library selection to "Aux file import"

5 participants

@caitlinlilley @Siedlerchr @koppor @ThiloteE @calixtus