Skip to content

Add TexShop Icon#10447

Merged
calixtus merged 1 commit into
mainfrom
texshopIcon
Oct 3, 2023
Merged

Add TexShop Icon#10447
calixtus merged 1 commit into
mainfrom
texshopIcon

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Oct 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

I traced the bitmap and tried to recreate this icon in Inkscape, however, in Icomoon in our font we can only use one color.
My first attempt was to fill the inner circle and have the TeX white or with the difference; however, that was not successful and one could not read it.

Still better than nothing...

grafik

texshop_raw_colorlogoonly

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 3, 2023
@github-actions

github-actions Bot commented Oct 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@calixtus calixtus enabled auto-merge October 3, 2023 18:14
@calixtus calixtus added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 16b5a3c Oct 3, 2023
@calixtus calixtus deleted the texshopIcon branch October 3, 2023 18:27
@koppor

koppor commented Oct 6, 2023

Copy link
Copy Markdown
Member

Interestingly, we have a similar icon for TeXStudio ^^.

image

Nice work of you though!

@Siedlerchr

Siedlerchr commented Oct 6, 2023

Copy link
Copy Markdown
Member Author

Yes, the TeX is similar. https://de.m.wikipedia.org/wiki/Datei:TeXShop_icon.png

Siedlerchr added a commit that referenced this pull request Oct 6, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fixSavingFileLockNe…
bb27bba 
…tworkShare

* upstream/main:
  Infer DOI from ArXiv identifier (#10449)
  Add TexShop Icon (#10447)
  Fix PDF export (#10361)

# Conflicts:
#	CHANGELOG.md
Siedlerchr added a commit that referenced this pull request Oct 8, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix/ui-improvement-…
46bad1d 
…in-protected-terms-files

* upstream/main:
  Update src/main/java/org/jabref/logic/exporter/AtomicFileOutputStream.java
  Fix saving on network drive under macOS
  Infer DOI from ArXiv identifier (#10449)
  Add TexShop Icon (#10447)
  Fix PDF export (#10361)
  Fixed SpringerFetcherTest and ACMPortalFetcherTest (#10445)
  Bump org.openrewrite.rewrite from 6.3.11 to 6.3.16 (#10442)
  Update all of lucene
  Bump org.apache.lucene:lucene-core from 9.7.0 to 9.8.0
  Bump com.dlsc.gemsfx:gemsfx from 1.77.0 to 1.82.0
  Accept LaTeX errors in comment field (#10436)
  fix checkstyle
  fix escaping of slashes
  fix checkstyle  and l10n
  Add TeXShop (macOS only)
@koppor koppor mentioned this pull request Mar 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Siedlerchr @koppor @calixtus