Fix NPEs in UrlCleanup#10435
Merged
Merged
Conversation
"Move URL in note field to url field" was causing NPEs
Contributor
|
Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues. More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html. |
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
koppor
approved these changes
Oct 1, 2023
calixtus
approved these changes
Oct 1, 2023
6 tasks
Siedlerchr
added a commit
that referenced
this pull request
Oct 3, 2023
* upstream/main: (94 commits) Bump org.openrewrite.rewrite from 6.3.11 to 6.3.16 (#10442) Update all of lucene Bump org.apache.lucene:lucene-core from 9.7.0 to 9.8.0 Bump com.dlsc.gemsfx:gemsfx from 1.77.0 to 1.82.0 Accept LaTeX errors in comment field (#10436) Fix NPEs in UrlCleanup (#10435) Fix triggering workflows (#10433) Show exception in cleanup error (#10430) Exclude check for ampersand (&) at verbatim fields (#10419) fix checkstyle fix escaping of slashes fix checkstyle and l10n Add TeXShop (macOS only) Fix casing First set fetcherWorker properties, then start the worker improve variable names checkstyle Fix fetcher worker execution on background thread Update contributing.md jakarta ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Move URL in note field to url field" was causing NPEs
Refs https://discourse.jabref.org/t/cleanup-entries-cant-get-it-to-work/3999/6?u=siedlerchr
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)