Skip to content

Remove JSpecify salt#10240

Merged
Siedlerchr merged 3 commits into
mainfrom
remove-jspecify
Aug 29, 2023
Merged

Remove JSpecify salt#10240
Siedlerchr merged 3 commits into
mainfrom
remove-jspecify

Conversation

@koppor

@koppor koppor commented Aug 29, 2023

Copy link
Copy Markdown
Member

Follow-up to #10227

Remove JSpecify.

Although JSpecify is cool and annotations can be made, the concrete usage should be more "useful". A follow-up PR can add a real example, code howto, and an ADR.

Link to the stackoverflow question for null annotations: https://stackoverflow.com/q/4963300/873282

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the dev: code-quality Issues related to code or architecture decisions label Aug 29, 2023
@koppor koppor mentioned this pull request Aug 29, 2023
6 tasks
@JabRef JabRef deleted a comment from github-actions Bot Aug 29, 2023
@Siedlerchr Siedlerchr merged commit ea620c4 into main Aug 29, 2023
@Siedlerchr Siedlerchr deleted the remove-jspecify branch August 29, 2023 11:26
@github-actions

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor mentioned this pull request Dec 22, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: code-quality Issues related to code or architecture decisions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants