Skip to content

Fix code style "SaveOrder preference should be self contained"#10227

Merged
calixtus merged 4 commits into
mainfrom
fix-9869
Aug 28, 2023
Merged

Fix code style "SaveOrder preference should be self contained"#10227
calixtus merged 4 commits into
mainfrom
fix-9869

Conversation

@koppor

@koppor koppor commented Aug 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/171

Minor:

image

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

calixtus
calixtus previously approved these changes Aug 28, 2023
View reviewed changes
@koppor koppor changed the title Fix "Entries not reordered after save" Fix code style "SaveOrder preference should be self contained" Aug 28, 2023
@koppor koppor added dev: code-quality Issues related to code or architecture decisions component: slr labels Aug 28, 2023
@github-actions

github-actions Bot commented Aug 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor

koppor commented Aug 28, 2023

Copy link
Copy Markdown
Member Author

Saving using table-sort-order still doesn't work (refs #9869). Will be in a follow-up pull request.

@calixtus calixtus merged commit c385eb4 into main Aug 28, 2023
@calixtus calixtus deleted the fix-9869 branch August 28, 2023 23:45
@calixtus

calixtus commented Aug 28, 2023

Copy link
Copy Markdown
Member

No risk, no fun.

@Siedlerchr Siedlerchr restored the fix-9869 branch August 29, 2023 06:45
Siedlerchr added a commit that referenced this pull request Aug 29, 2023
@Siedlerchr
Revert "Fix code style "SaveOrder preference should be self contained" (
899bdf8 
#10227)"

This reverts commit c385eb4.
@Siedlerchr Siedlerchr mentioned this pull request Aug 29, 2023
Closed
@koppor koppor mentioned this pull request Aug 29, 2023
Merged
6 tasks
@Siedlerchr

Siedlerchr commented Aug 29, 2023

Copy link
Copy Markdown
Member

Why is there a new library jspecify for non nulls? One of the thousands of NonNull librarys

@koppor koppor mentioned this pull request Aug 29, 2023
Merged
6 tasks
@koppor koppor deleted the fix-9869 branch September 12, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixtus calixtus calixtus left review comments

Assignees

No one assigned

Labels

component: slr dev: code-quality Issues related to code or architecture decisions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koppor @calixtus @Siedlerchr