Conversation
Member
Member
Author
|
No, the pipe char is hardcoded in the java-keyring library. |
Member
Author
|
Some implementation changes were discussed: |
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
koppor
reviewed
Jul 1, 2023
koppor
approved these changes
Jul 1, 2023
Contributor
|
Was this tested and confirmed using Ubuntu / GNOME? It doesn't work as Keyring.create() repeatedly returns null. I'd say this is OS specific, but do we understand where and when it won't work? When not possible, password saving probably shouldn't be provided as an option (as it's misleading behaviour). Current behaviour is to swallow exceptions, etc... |
6 tasks
This was referenced Aug 30, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



follow up to #9652
fixes #9652 (comment)
Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/106
depends on #10004
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)