Skip to content

Remove listeners in RedoAction for memory efficiency #11809

Closed
#11839
Closed
Remove listeners in RedoAction for memory efficiency#11809
#11839
Assignees
melisolmez
Labels
FirstTimeCodeContributionTriggers GitHub Greeter Workflow[outdated] type: enhancementgood first issueAn issue intended for project-newcomers. Varies in difficulty.
Milestone
6.0-beta
@subhramit

Description

@subhramit
subhramit
opened on Sep 23, 2024

Context: PR #11758
Based on the TODO comment:

jabref/src/main/java/org/jabref/gui/undo/RedoAction.java

Lines 24 to 28 in 8412e65

// TODO: The old listener should be removed. Otherwise, memory consumption will increase.
stateManager.activeTabProperty().addListener((observable, oldValue, activeLibraryTab) -> {
activeLibraryTab.ifPresent(libraryTab ->
this.executable.bind(libraryTab.getUndoManager().getRedoableProperty()));
});

Refs. #11758 (comment)

Metadata

Metadata

Assignees

Labels

FirstTimeCodeContributionTriggers GitHub Greeter Workflow[outdated] type: enhancementgood first issueAn issue intended for project-newcomers. Varies in difficulty.

Type

No type

Fields

No fields configured for issues without a type.

Projects

Good First Issues
Status
Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions