Enable/Disable the undo and redo toolbar/menu buttons correctly#11758
Merged
Conversation
Siedlerchr
approved these changes
Sep 13, 2024
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
from my side looks good but better have olly and carl take a look s well
calixtus
approved these changes
Sep 13, 2024
koppor
reviewed
Sep 14, 2024
| // TODO: Rework the UndoManager to something like the following, if it had a property. | ||
| // this.executable.bind(frame.getCurrentBasePanel().getUndoManager().canUndo()) | ||
| this.executable.bind(ActionHelper.needsDatabase(stateManager)); | ||
| stateManager.activeTabProperty().addListener((observable, oldValue, activeLibraryTab) -> { |
Member
There was a problem hiding this comment.
This will add a listener after each tab change. The old listener should be removed. Otherwise, memory consumption will increase IMHO.
6 tasks
This was referenced Sep 16, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8807
Screenshots
Redo button is disabled
Undo button is disabled
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)