Maintenance / Minor changes#952
Merged
bcoconni merged 7 commits intoJSBSim-Team:masterfrom Sep 1, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #952 +/- ##
==========================================
+ Coverage 24.89% 24.90% +0.01%
==========================================
Files 168 168
Lines 18887 18890 +3
==========================================
+ Hits 4701 4704 +3
Misses 14186 14186
|
Member
|
All looks good to me. |
Member
Author
|
Good ! I've also added some further changes to the unit tests:
|
bcoconni
added a commit
to bcoconni/jsbsim
that referenced
this pull request
Sep 2, 2023
* Remove useless parameters. * Increase the sleep time in `TestInputSocket.py` to avoid failures with MSVC. * Fix the deprecated method `lookup` from pandas. * A couple of small improvements to `FGPropertyManager::Unbind()`. * Fix the supported versions of the Python language in `README.md` * Improvements to some unit tests. * Fix a number of small details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings a number of minor changes:
README.md.FGInitialCondition::Load()is renamed fromuseStoredPathtouseAircraftPathwhich, I think, is more explicit.FGPropertyManager::Unbind()that takes astd::shared_ptrargument. This avoids explicitly calling the methodstd::shared_ptr::get()when usingUnbind()i.e. this is syntactic sugar 😃FindDifferencesinJSBSim_utils.pyas theDataFrames.lookupmethod is now obsolete in the librarypandas2.0.getOutputhas been increased from 0.5s to 1.0s in the test caseTestInputSocket.py. This is to avoid this test to randomly fail with MSVC when our CI workflow is executed on GitHub.